Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LinkedHashMap to OrderedMap #2349

Closed
sethladd opened this issue Mar 29, 2012 · 11 comments
Closed

Rename LinkedHashMap to OrderedMap #2349

sethladd opened this issue Mar 29, 2012 · 11 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

The name LinkedHashMap is not clear in its intent. We suggest OrderedMap as a better interface name. We suspect this name will be easier to understand and identify for JavaScript developers browsing the APIs.

@DartBot
Copy link

DartBot commented Mar 29, 2012

This comment was originally written by jjb@google.com


Better still is to get rid of the interface entirely, and simply implement the Map interface.

@sethladd
Copy link
Contributor Author

Will there be an implementation of an ordered map? If so, thoughts on name?

@DartBot
Copy link

DartBot commented Mar 29, 2012

This comment was originally written by jjb@google.com


I was going to keep the name LinkedHashMap. InsertionOrderedMap would be another possibility, though LinkedHashMap is familiar to Java programmers. Do you believe that InsertionOrderedMap would be a much better name for Javascript programmers?

@sethladd
Copy link
Contributor Author

I'm at a JavaScript summit right now actually and LinkedHashMap was unfamiliar to this crowd. You're right, it's very Java. InsertionOrderedMap is more clear about "what it does", as LinkedHashMap sounds like "how it does it"

@gbracha
Copy link
Contributor

gbracha commented Apr 12, 2012

Recategorizing as this has nothing to do with language area.


Removed Area-Language label.
Added Area-Library label.

@sethladd
Copy link
Contributor Author

cc @lrhn.

@sethladd
Copy link
Contributor Author

Thoughts on this?

I see LinkedHashMap is still in trunk.

http://api.dartlang.org/docs/trunk/latest/dart_core/LinkedHashMap.html


cc @floitschG.

@floitschG
Copy link
Contributor

It's on my TODO list.
Currently I prefer InsertionOrderedMap.


Added Accepted label.

@DartBot
Copy link

DartBot commented Feb 17, 2013

This comment was originally written by @sethladd


I see this doesn't have a Milestone. I think it missed M3, will it get into M4?

(I ask because I want to know what kind of disclaimer to add to some docs :)

@floitschG
Copy link
Contributor

Added this to the M4 milestone.

@floitschG
Copy link
Contributor

In the end we will keep the "Linked" prefix.
We are still planning on making the default implementations of Map and Set point to the Linked versions, though.
  var m = new Map() would be the linked version.


Removed this from the M4 milestone.
Added WontFix label.

@sethladd sethladd added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels May 6, 2013
@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug and removed resolution-wont_fix labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants