Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of URIs with empty authority is wrong #2216

Closed
peter-ahe-google opened this issue Mar 18, 2012 · 11 comments
Closed

Handling of URIs with empty authority is wrong #2216

peter-ahe-google opened this issue Mar 18, 2012 · 11 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core

Comments

@peter-ahe-google
Copy link
Contributor

We currently special case file URIs by adding // but this doesn't work on Windows and doesn't work for non-file schemes.

@peter-ahe-google
Copy link
Contributor Author

Added Accepted label.

@peter-ahe-google
Copy link
Contributor Author

Added this to the M1 milestone.
Removed Priority-Medium label.
Added Priority-Critical label.

@peter-ahe-google
Copy link
Contributor Author

Added Started label.

@peter-ahe-google
Copy link
Contributor Author

Not a priority for M1.


Removed this from the M1 milestone.
Added this to the Later milestone.
Removed Priority-Critical label.
Added Priority-Medium label.

@lrhn
Copy link
Member

lrhn commented Apr 25, 2014

cc @sgjesse.
Added Library-Core label.

@lrhn
Copy link
Member

lrhn commented Jun 23, 2014

File URIs are special in that their format requires the // of the authority, even if the authority is empty (RFC 1738). That is why we explicitly add the "//" in the toString, even with no authority.

I'll add handling of paths starting with "//" and no authority. These need the "//" even if they are not file paths.


Added AsDesigned label.

@peter-ahe-google
Copy link
Contributor Author

We also do things like:

Uri.parse('org-dartlang-foo:///fisk.txt').toString() -> 'org-dartlang-foo:/fisk.txt'.


Set owner to @lrhn.
Added Triaged label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@lrhn
Copy link
Member

lrhn commented Jul 18, 2014

Are the issues fixed now?


Added NeedsInfo label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@lrhn
Copy link
Member

lrhn commented Sep 30, 2014

Added Fixed label.

@peter-ahe-google peter-ahe-google added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core labels Sep 30, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core
Projects
None yet
Development

No branches or pull requests

3 participants