http/xhr_test.dart should update its expectations for server response headers from dart:io #20580
Comments
|
Having a test that checks that XHR headers are actually working is a good thing. However it should only check for headers that we know are there, that is something that the test server provides. The current resource being read is '/root_dart/tests/html/xhr_cross_origin_data.txt?cacheBlock=$cacheBlocker', so the header 'content-type:text/plain; charset=utf-8' should be set if the test server is behaving correctly. Another option is to add an additional fixed entrypoint in the test server which can deliver arbitrary headers, e.g.: /generate_headers?foo=bar&dart=cool will return a response with the headers foo:bar We should also be testing that headers set on XHR is send to the server. One option could be /headers_to_body which will return the headers in the body somehow, either as application/x-www-form-urlencoded or application/json. |
kevmoo
added
the
area-core-library
kevmoo
added
P2
There is a test that currently expects the HTTP server serving test files and data to provide a server header server: 'Dart/0.1 (dart:io)'
Recent changes make HttpServer provide other default headers, and no server header. Either the test should be changed to expect what it provides. The new headers provided by bleeding-edge Dart are:
access-control-allow-origin:*
cache-control:max-age=30
content-encoding:gzip
content-type:text/plain; charset=utf-8
x-content-type-options:nosniff
x-xss-protection:1; mode=block
And the old headers provided by the Dart in tools/testing/bin/linux/dart are:
access-control-allow-origin:*
content-encoding:gzip
server:Dart/1.0 (dart:io)
transfer-encoding:chunked
Feel free to assign the bug to me, and give your input on whether we should be testing these default headers.
The text was updated successfully, but these errors were encountered: