Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer error message not formatted in Editor #20564

Closed
anders-sandholm opened this issue Aug 18, 2014 · 14 comments
Closed

Polymer error message not formatted in Editor #20564

anders-sandholm opened this issue Aug 18, 2014 · 14 comments
Assignees
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Milestone

Comments

@anders-sandholm
Copy link
Contributor

Dart Editor version 1.6.0.dev_09_03 (DEV)
Dart SDK version 1.6.0-dev.9.3

The todomvc sample printed this unformatted message:
flushing %s elements (http://localhost:8080/packages/polymer/src/js/polymer/polymer.js:12)

Not clear if this is an Editor or Polymer bug. Assigning to Editor for now.

@clayberg
Copy link

Set owner to @keertip.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@sethladd
Copy link
Contributor

where did the message appear?

@bwilkerson
Copy link
Member

As far as I can tell, this message is not produced by Editor.

@sethladd
Copy link
Contributor

Looks like a debug message and not critical, so keeping at Medium.


Removed the owner.
Removed Area-Editor label.
Added Area-Pkg, Pkg-Polymer labels.

@sigmundch
Copy link
Member

I believe this is an editor bug.

The polymer.js library now prints a formatted message, where %s is replaced by a number. The print normally comes formatted correctly in the chrome console, but if you launch the app from the editor, the editor console shows %s.


Removed Area-Pkg, Pkg-Polymer labels.
Added Area-Editor label.

@clayberg
Copy link

Set owner to @keertip.

@sethladd
Copy link
Contributor

sethladd commented Sep 4, 2014

How do you reproduce this bug?


Added NeedsInfo label.

@sethladd
Copy link
Contributor

sethladd commented Sep 4, 2014

Set owner to @anders-sandholm.

@sigmundch
Copy link
Member

I think you can repro by just doing this:
 - Open todomvc in the editor
 - launch Dartium
 - see the console output in the Editor.

@sethladd
Copy link
Contributor

sethladd commented Sep 4, 2014

I did that, but I only see pub bootstrap stuff and then a bunch of GET requests. Maybe I missed it?

--- 12:46:39 PM Auto running pub get on /Users/sethladd/dart/todomvc ... ---
Resolving dependencies...

  • analyzer 0.22.4
  • args 0.12.0+2
  • barback 0.15.0+1
  • browser 0.10.0+2
  • code_transformers 0.2.2
  • collection 1.0.0
  • csslib 0.11.0+2
  • html5lib 0.12.0
  • logging 0.9.2
  • matcher 0.10.1+1 (0.11.1 available)
  • mock 0.10.0+1 (0.11.0+2 available)
  • observe 0.12.0
  • path 1.3.0
  • polymer 0.12.2+1 (0.13.0+3 available)
  • polymer_expressions 0.12.0+1
  • pool 1.0.1
  • smoke 0.2.1
  • source_maps 0.10.0
  • source_span 1.0.0
  • stack_trace 0.9.3+2 (1.0.2 available)
  • string_scanner 0.1.0
  • template_binding 0.12.1
  • unittest 0.10.1+2 (0.11.0+5 available)
  • utf 0.9.0+1
  • watcher 0.9.3
  • web_components 0.5.0+1 (0.6.0+1 available)
  • yaml 2.0.1+1
    Downloading polymer 0.12.2+1...
    Downloading code_transformers 0.2.2...
    Downloading web_components 0.5.0+1...
    Downloading yaml 2.0.1+1...
    Changed 27 dependencies!

--- 12:47:03 PM Starting pub serve : todomvc ---
Loading source assets...
Loading polymer/src/build/mirrors_remover, observe and smoke/src/default_transformer transformers...
Loading polymer transformers...
Serving todomvc web on http://localhost:8080
Build completed successfully
[web] GET /index.html => todomvc|web/index.html
[web] GET /packages/polymer/src/build/log_injector.css => polymer|lib/src/build/log_injector.css
[web] GET /index.html_bootstrap.dart => todomvc|web/index.html_bootstrap.dart
[web] GET /packages/browser/dart.js => browser|lib/dart.js
[web] GET /packages/web_components/dart_support.js => web_components|lib/dart_support.js
[web] GET /packages/web_components/platform.js => web_components|lib/platform.js
[web] GET /packages/polymer/src/js/polymer/polymer.js => polymer|lib/src/js/polymer/polymer.js
[web] GET /packages/polymer/polymer.dart => polymer|lib/polymer.dart
[web] GET /lib-elements/polymer_localstorage.dart => todomvc|web/lib-elements/polymer_localstorage.dart
[web] GET /elements/td_model.dart => todomvc|web/elements/td_model.dart
[web] GET /lib-elements/simple_router.dart => todomvc|web/lib-elements/simple_router.dart
[web] GET /elements/td_input.dart => todomvc|web/elements/td_input.dart
[web] GET /elements/td_item.dart => todomvc|web/elements/td_item.dart
[web] GET /elements/td_todos.dart => todomvc|web/elements/td_todos.dart
[web] GET /index.html.0.dart => todomvc|web/index.html.0.dart
[web] GET /packages/smoke/smoke.dart => smoke|lib/smoke.dart
[web] GET /packages/polymer/src/build/log_injector.dart => polymer|lib/src/build/log_injector.dart
[web] GET /packages/smoke/static.dart => smoke|lib/static.dart
[web] GET /packages/observe/src/observable_list.dart => observe|lib/src/observable_list.dart
[web] GET /packages/logging/logging.dart => logging|lib/logging.dart
[web] GET /packages/observe/observe.dart => observe|lib/observe.dart
[web] GET /packages/observe/src/metadata.dart => observe|lib/src/metadata.dart
[web] GET /packages/observe/src/dirty_check.dart => observe|lib/src/dirty_check.dart
[web] GET /packages/polymer_expressions/polymer_expressions.dart => polymer_expressions|lib/polymer_expressions.dart
[web] GET /packages/polymer/auto_binding.dart => polymer|lib/auto_binding.dart
[web] GET /packages/template_binding/template_binding.dart => template_binding|lib/template_binding.dart
[web] GET /packages/polymer/deserialize.dart => polymer|lib/deserialize.dart
[web] GET /packages/polymer/src/static_loader.dart => polymer|lib/src/static_loader.dart
[web] GET /packages/observe/html.dart => observe|lib/html.dart
[web] GET /packages/polymer/src/instance.dart => polymer|lib/src/instance.dart
[web] GET /packages/polymer/src/events.dart => polymer|lib/src/events.dart
[web] GET /packages/polymer/src/declaration.dart => polymer|lib/src/declaration.dart
[web] GET /packages/smoke/src/implementation.dart => smoke|lib/src/implementation.dart
[web] GET /packages/polymer/src/loader.dart => polymer|lib/src/loader.dart
[web] GET /packages/polymer/src/property_accessor.dart => polymer|lib/src/property_accessor.dart
[web] GET /packages/polymer/init.dart => polymer|lib/init.dart
[web] GET /packages/smoke/src/common.dart => smoke|lib/src/common.dart
[web] GET /packages/path/path.dart => path|lib/path.dart
[web] GET /packages/observe/src/list_diff.dart => observe|lib/src/list_diff.dart
[web] GET /packages/observe/src/bindable.dart => observe|lib/src/bindable.dart
[web] GET /packages/observe/src/bind_property.dart => observe|lib/src/bind_property.dart
[web] GET /packages/polymer/src/job.dart => polymer|lib/src/job.dart
[web] GET /packages/observe/src/change_notifier.dart => observe|lib/src/change_notifier.dart
[web] GET /packages/observe/src/list_path_observer.dart => observe|lib/src/list_path_observer.dart
[web] GET /packages/observe/src/change_record.dart => observe|lib/src/change_record.dart
[web] GET /packages/observe/src/observable.dart => observe|lib/src/observable.dart
[web] GET /packages/observe/src/observable_box.dart => observe|lib/src/observable_box.dart
[web] GET /packages/observe/src/observable_map.dart => observe|lib/src/observable_map.dart
[web] GET /packages/observe/src/observer_transform.dart => observe|lib/src/observer_transform.dart
[web] GET /packages/observe/src/to_observable.dart => observe|lib/src/to_observable.dart
[web] GET /packages/observe/src/path_observer.dart => observe|lib/src/path_observer.dart
[web] GET /packages/polymer_expressions/eval.dart => polymer_expressions|lib/eval.dart
[web] GET /packages/polymer_expressions/expression.dart => polymer_expressions|lib/expression.dart
[web] GET /packages/polymer_expressions/parser.dart => polymer_expressions|lib/parser.dart
[web] GET /packages/polymer_expressions/src/globals.dart => polymer_expressions|lib/src/globals.dart
[web] GET /packages/template_binding/src/binding_delegate.dart => template_binding|lib/src/binding_delegate.dart
[web] GET /packages/template_binding/src/instance_binding_map.dart => template_binding|lib/src/instance_binding_map.dart
[web] GET /packages/template_binding/src/mustache_tokens.dart => template_binding|lib/src/mustache_tokens.dart
[web] GET /packages/template_binding/src/node.dart => template_binding|lib/src/node.dart
[web] GET /packages/template_binding/src/template.dart => template_binding|lib/src/template.dart
[web] GET /packages/template_binding/src/template_iterator.dart => template_binding|lib/src/template_iterator.dart
[web] GET /packages/path/src/context.dart => path|lib/src/context.dart
[web] GET /packages/path/src/style.dart => path|lib/src/style.dart
[web] GET /packages/utf/utf.dart => utf|lib/utf.dart
[web] GET /packages/path/src/path_exception.dart => path|lib/src/path_exception.dart
[web] GET /packages/polymer_expressions/async.dart => polymer_expressions|lib/async.dart
[web] GET /packages/polymer_expressions/filter.dart => polymer_expressions|lib/filter.dart
[web] GET /packages/polymer_expressions/visitor.dart => polymer_expressions|lib/visitor.dart
[web] GET /packages/polymer_expressions/tokenizer.dart => polymer_expressions|lib/tokenizer.dart
[web] GET /app/bg.png => todomvc|web/app/bg.png
[web] GET /packages/path/src/parsed_path.dart => path|lib/src/parsed_path.dart
[web] GET /packages/path/src/internal_style.dart => path|lib/src/internal_style.dart
[web] GET /packages/path/src/style/posix.dart => path|lib/src/style/posix.dart
[web] GET /packages/path/src/style/url.dart => path|lib/src/style/url.dart
[web] GET /packages/utf/src/constants.dart => utf|lib/src/constants.dart
[web] GET /packages/path/src/style/windows.dart => path|lib/src/style/windows.dart
[web] GET /packages/utf/src/list_range.dart => utf|lib/src/list_range.dart
[web] GET /packages/utf/src/utf_16_code_unit_decoder.dart => utf|lib/src/utf_16_code_unit_decoder.dart
[web] GET /packages/utf/src/util.dart => utf|lib/src/util.dart
[web] GET /packages/utf/src/utf/utf_stream.dart => utf|lib/src/utf/utf_stream.dart
[web] GET /packages/utf/src/utf/utf8.dart => utf|lib/src/utf/utf8.dart
[web] GET /packages/path/src/characters.dart => path|lib/src/characters.dart
[web] GET /packages/utf/src/utf/utf32.dart => utf|lib/src/utf/utf32.dart
[web] GET /packages/utf/src/utf/utf16.dart => utf|lib/src/utf/utf16.dart
[web] GET /packages/path/src/utils.dart => path|lib/src/utils.dart
[web] GET /index.html._buildLogs => todomvc|web/index.html._buildLogs
[web] GET /favicon.ico => Could not find asset todomvc|web/favicon.ico.

@sigmundch
Copy link
Member

Just checked - there is a separate tab for the browser output (in this case it's labeled "index.html"), next to Tools Output

@sethladd
Copy link
Contributor

sethladd commented Sep 4, 2014

Indeed! Thanks :)

And yes, when I look inside the JS Console of Dartium, I see:

flushing 10 elements

But in editor's index.html panel/view, I see:

flushing %s elements

@sethladd
Copy link
Contributor

sethladd commented Sep 4, 2014

This is annoying, but has a workaround (open the Dartium console). Will close for now.


Added NotPlanned label.

@clayberg
Copy link

Added this to the 1.7 milestone.

@anders-sandholm anders-sandholm added Type-Defect closed-not-planned Closed as we don't intend to take action on the reported issue labels Sep 11, 2014
@anders-sandholm anders-sandholm self-assigned this Sep 11, 2014
@anders-sandholm anders-sandholm added this to the 1.7 milestone Sep 11, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Development

No branches or pull requests

5 participants