Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server should report errors rather than crashing when the SDK is invalid #20562

Closed
bwilkerson opened this issue Aug 17, 2014 · 1 comment
Closed

Server should report errors rather than crashing when the SDK is invalid #20562

bwilkerson opened this issue Aug 17, 2014 · 1 comment
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@bwilkerson
Copy link
Member

The analysis server should verify that the path passed in on the command-line is valid. If not, it should report a fatal error and shutdown. This behavior should be documented in the spec.

However, it should be tolerant of having a directory separator at the end of the passed in path.

See https://groups.google.com/a/dartlang.org/forum/#!topic/analyzer-discuss/7NL4L4blLZg for additional information.
@bwilkerson bwilkerson added Type-Defect area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-server labels Aug 17, 2014
@bwilkerson bwilkerson removed the Triaged label Nov 4, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed Priority-Medium labels Mar 1, 2016
@stereotype441 stereotype441 removed their assignment Aug 15, 2016
@srawlins
Copy link
Member

dart analyze is tolerant of trailing slashes, and reports errors when a path is invalid. I'll close this as fixed.

$ dart analyze pkg/dartdev
Analyzing dartdev...                   15.7s
No issues found!
$ dart analyze pkg/dartdev/
Analyzing dartdev...                   3.5s
No issues found!
$ dart analyze pkg/dartde
Directory or file doesn't exist: pkg/dartde

Usage: dart analyze [arguments] [<directory>]
-h, --help                   Print this usage information.
    --fatal-infos            Treat info level issues as fatal.
    --[no-]fatal-warnings    Treat warning level issues as fatal.
                             (defaults to on)

Run "dart help" to see global options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @srawlins @stereotype441 @bwilkerson