Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create a script snapshot file when snapshot generation fails #20504

Closed
nex3 opened this issue Aug 13, 2014 · 6 comments
Closed

Don't create a script snapshot file when snapshot generation fails #20504

nex3 opened this issue Aug 13, 2014 · 6 comments
Assignees
@zanderso
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@nex3
Copy link
Member

nex3 commented Aug 13, 2014

Currently if the VM fails to generate a snapshot (due to a syntax error in an input file, for example) it creates an empty file at the snapshot location. This is unexpected behavior, and inconsistent with other tools.
@iposva-google
Copy link
Contributor

Set owner to @rmacnak-google.
Removed Priority-Unassigned label.
Added Priority-Medium, Accepted labels.

@iposva-google
Copy link
Contributor

Set owner to @zanderso.

@zanderso
Copy link
Member

I took a look at gen_snapshot code, and it appeared to correctly handle error cases. Note the CHECK_RESULT after Dart_CreateSnapshot in CreateAndWriteSnapshot, which will exit the program if anything goes wrong, in addition to the exception raised by FullSnapshotWriter::WriteFullSnapshot(), both of which prevent execution reaching the call to WriteSnapshotFile() in case of error.

I also introduced a syntax error into an input file and noted that gen_snapshot exited with an error message and that no snapshot file was created in both Debug and Release configurations.

Marking as CannotReproduce absent more detailed reproduction steps.

Added CannotReproduce label.

@nex3
Copy link
Member Author

nex3 commented Aug 26, 2014

I'm confused... if you can't reproduce this, what's https://codereview.chromium.org/499743002/ for?

@iposva-google
Copy link
Contributor

We finally figured out what you were trying to report: Creation of script snapshots and not creation of full snapshots.

Bug was not updated to reflect that. Now it is...

Added Accepted label.
Changed the title to: "Don't create a script snapshot file when snapshot generation fails".

@zanderso
Copy link
Member

zanderso commented Sep 8, 2014

Fixed in r39998 by https://codereview.chromium.org/499743002/

Added Fixed label.

@nex3 nex3 added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Sep 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanderso zanderso

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nex3 @iposva-google @zanderso