Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support release mode dart editors "pub build" #20481

Closed
DartBot opened this issue Aug 12, 2014 · 6 comments
Closed

Support release mode dart editors "pub build" #20481

DartBot opened this issue Aug 12, 2014 · 6 comments
Assignees
@keertip
Labels
type-enhancement A request for a change that isn't a bug
Milestone
1.9

Comments

@DartBot
Copy link

DartBot commented Aug 12, 2014

This issue was originally filed by @pjako

Currently if you press "pub build" in the dart editor the pub build command does not set a mode.
So all transformers gets the BarbackSettings Debug mode.
But it really should be release, or at least there should be an option to do a "pub build" with release mode (inside the editor).
Dart Editors "pub build" should be equal to the command "pub serve --mode release"

See discussion:
https://groups.google.com/a/dartlang.org/forum/?fromgroups#!topic/misc/DHmXc8O0qV8
@dgrove
Copy link
Contributor

dgrove commented Aug 12, 2014

cc @munificent.
Added Area-Editor, Triaged labels.

@clayberg
Copy link

Set owner to @keertip.
Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-Medium labels.

@sethladd
Copy link
Contributor

I do think it's important to allow the developer to choose "pub build debug" or "pub build production release".

Hi Keerti,
Could you take a look at what it will take to address this? There have been multiple reports for this one.

Workaround: run pub build from the command line.

cc @sigmundch.

@sethladd
Copy link
Contributor

Added Editor-Building label.

@DartBot
Copy link
Author

DartBot commented Sep 30, 2014

This comment was originally written by marcin...@avstudios.com

Hi Seth,

Any news about this option? It's not great to run transformers every time we want to test an app. I hope it's a way to make it work in near future.

@keertip
Copy link
Contributor

keertip commented Feb 18, 2015

Added menu options to run pub build in debug and release mode.

Added this to the 1.9 milestone.
Added Fixed label.

@DartBot DartBot added this to the 1.9 milestone Feb 18, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keertip keertip

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
6 participants
@sethladd @kevmoo @dgrove @keertip @clayberg @DartBot