Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot rename variables that are marked as errors. #20450

Closed
DartBot opened this issue Aug 10, 2014 · 11 comments
Closed

Cannot rename variables that are marked as errors. #20450

DartBot opened this issue Aug 10, 2014 · 11 comments
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Aug 10, 2014

This issue was originally filed by george.moschovitis...@gmail.com


In the current editor, for a variable is marked error (i.e. underlined with a yellow curly line), when your right click, there is no option to rename it.

@sgjesse
Copy link
Contributor

sgjesse commented Aug 11, 2014

Added Area-Editor label.

@sgjesse
Copy link
Contributor

sgjesse commented Aug 11, 2014

Added Triaged label.

@clayberg
Copy link

Set owner to @scheglov.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@scheglov
Copy link
Contributor

Example please.


Added NeedsInfo label.

@sethladd
Copy link
Contributor

Hi George,

Did you have a code snippet for us to look at?

@sethladd
Copy link
Contributor

I was able to reproduce this. It would be great if the analyzer could do some fuzzy matching and try to suggest renames of names that are misspelled.

foo() {}

void main() {
  fo(); // <==== try to rename this
}


Removed the owner.
Removed Area-Editor label.
Added Area-Analyzer, Triaged labels.
Changed the title to: "Cannot rename variables that are marked as errors.".

@DartBot DartBot added Type-Enhancement area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Aug 26, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
@srawlins
Copy link
Member

Is this a "Dart Editor" specific bug? Probably not our bug if it exists in IntelliJ

@bwilkerson
Copy link
Member

Nope. Analysis server provides refactoring support for IntelliJ.

@alexander-doroshko
Copy link

Hm, to me renaming misspelled var doesn't seem to be reasonable. "No Navigate To Declaration => no Rename" looks logical to me.

@scheglov
Copy link
Contributor

Agree.

@srawlins
Copy link
Member

srawlins commented Oct 9, 2023

Agree; I'll close this as no action needed. If someone wants to champion some feature like this, please file a new issue with examples.

@srawlins srawlins closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

9 participants