Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search.getTypeHierarchy doesn't traverse subclasses on Windows #20436

Closed
stereotype441 opened this issue Aug 8, 2014 · 6 comments
Closed

search.getTypeHierarchy doesn't traverse subclasses on Windows #20436

stereotype441 opened this issue Aug 8, 2014 · 6 comments
Assignees
Labels
analyzer-server area-analyzer closed-obsolete Closed as the reported issue is no longer relevant
Milestone

Comments

@stereotype441
Copy link
Member

For this file:

  class Base {}
  class Pivot /* target */ extends Base {}
  class Derived extends Pivot {}

sending search.getTypeHierarchy with an offset within the word "Pivot" yields this result:

  [
    {
      'classElement': {
        'kind': 'CLASS',
        'name': 'Pivot',
        'location': {
          'file': 'C:\Users\CHROME2\AppData\Local\Temp\analysisServerab55bdb2-1f43-11e4-8643-005056030161\test.dart',
          'offset': 20,
          'length': 5,
          'startLine': 2,
          'startColumn': 7
        },
        'flags': 0
      },
      'superclass': 1,
      'interfaces': [],
      'mixins': [],
      'subclasses': []
    },
    {
      'classElement': {
        'kind': 'CLASS',
        'name': 'Base',
        'location': {
          'file': 'C:\Users\CHROME
2\AppData\Local\Temp\analysisServerab55bdb2-1f43-11e4-8643-005056030161\test.dart',
          'offset': 6,
          'length': 4,
          'startLine': 1,
          'startColumn': 7
        },
        'flags': 0
      },
      'superclass': 2,
      'interfaces': [],
      'mixins': [],
      'subclasses': []
    },
    {
      'classElement': {
        'kind': 'CLASS',
        'name': 'Object',
        'location': {
          'file': 'E:\b\build\slave\pub-win-debug-be\build\dart\build\DebugIA32\dart-sdk\lib\core\object.dart',
          'offset': 834,
          'length': 6,
          'startLine': 21,
          'startColumn': 7
        },
        'flags': 0
      },
      'interfaces': [],
      'mixins': [],
      'subclasses': []
    }
  ]

Note that the class "Derived" does not appear.

Discovered via integration tests. For more information see:

http://build.chromium.org/p/client.dart/builders/pub-win-debug-be/builds/2681/steps/pub%20and%20pkg%20optimization%20counter%20threshold%205%20tests%20failures/logs/stdio

@bwilkerson
Copy link
Member

Removed Priority-Unassigned label.
Added Priority-Medium label.

@stereotype441
Copy link
Member Author

Fixed in revision 39105.


Added Fixed label.

@stereotype441
Copy link
Member Author

This test is still failing, though it now fails sporadically rather than all the time.


Added Triaged label.

@bwilkerson
Copy link
Member

Set owner to @scheglov.

@scheglov
Copy link
Contributor

scheglov commented Nov 6, 2014

Added AssumedStale label.

@clayberg
Copy link

Added this to the 1.8 milestone.

@stereotype441 stereotype441 added Type-Defect area-analyzer analyzer-server closed-obsolete Closed as the reported issue is no longer relevant labels Nov 28, 2014
@stereotype441 stereotype441 added this to the 1.8 milestone Nov 28, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-server area-analyzer closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Development

No branches or pull requests

4 participants