Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't disable breakpoints in packages code #20325

Closed
DartBot opened this issue Aug 1, 2014 · 7 comments
Closed

Can't disable breakpoints in packages code #20325

DartBot opened this issue Aug 1, 2014 · 7 comments
Assignees
@scheglov
Labels
closed-obsolete Closed as the reported issue is no longer relevant
Milestone
1.7

Comments

@DartBot
Copy link

DartBot commented Aug 1, 2014

This issue was originally filed by JeffRSprag...@gmail.com

What steps will reproduce the problem?

  1. Set a breakpoint in a package source file
  2. Disable it
  3. On subsequent runs, the breakpoint icon (the blue circle) shows off, but the debugger always break there anyway

Breakpoint survives restarts, state toggling, and even survived upgrading from 1.4.3 to 1.5.3 where the problem continued to persist.

Occasionally, I am able to select enable breakpoint (even though it's already breaking) and then disable breakpoint and it stops... until I start the app again and then it's back. Whatever file/database is keeping track of breakpoints is out of sync and totally messed up. Is there a big-hammer way to clear all breakpoints?

I made the mistake of setting a breakpoint in my event handler in a package file and now I can't develop and run my app without constantly having to try to reset the breakpoints.

This is latest Dart (1.5.3) First noticed in 1.4.3 using Dart editor on a new Mac Mavericks laptop.
@DartBot
Copy link
Author

DartBot commented Aug 1, 2014

This comment was originally written by JeffRSpra...@gmail.com

This is similar to 15153 and 19310, but seen in the latest code, and finding that it survives restarting the editor, bringing development to a grinding halt.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Added Area-Editor, Triaged labels.

@clayberg
Copy link

cc @keertip.
Set owner to @devoncarew.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@sethladd
Copy link
Contributor

Added Editor-Debugging label.

@clayberg
Copy link

cc @scheglov.

@scheglov
Copy link
Contributor

Works for me.
Once I disable the breakpoint, I see the corresponding "removeBreakpoint" command issued.
And, as expected, the breakpoint is not hit when we call this "package:path" functions second time.

[1050.608 ==> {"id":6,"command":"setBreakpoint","params":{"isolateId":623969512,"line":48,"url":"package:path/src/parsed_path.dart"}}]
[1050.609 <== { "id": 6, "result": { "breakpointId": 1 }}]
[1050.634 <== { "event": "paused", "params": { "reason": "breakpoint", "isolateId": 623969512,"breakpointId": 1,"location": { "url":"package:path/src/parsed_path.dart","libraryId":19,"tokenOffset":144}}}]
[1065.675 ==> {"id":15,"command":"removeBreakpoint","params":{"isolateId":623969512,"breakpointId":1}}]
[1065.675 <== { "id": 15 }]
[1066.374 ==> {"id":16,"command":"resume","params":{"isolateId":623969512}}]
[1066.375 <== { "id": 16 }]
[1066.376 <== { "event": "isolate", "params": { "reason": "shutdown", "id": 623969512 }}]

cc @devoncarew.
Set owner to @scheglov.
Added AssumedStale label.

@clayberg
Copy link

Added this to the 1.7 milestone.

@DartBot DartBot added Type-Defect closed-obsolete Closed as the reported issue is no longer relevant labels Sep 29, 2014
@DartBot DartBot added this to the 1.7 milestone Sep 29, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
5 participants
@sethladd @scheglov @kasperl @clayberg @DartBot