Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symlinking pkg/observatory is making pkgbuild failing #20306

Closed
ricowind opened this issue Aug 1, 2014 · 3 comments
Closed

Symlinking pkg/observatory is making pkgbuild failing #20306

ricowind opened this issue Aug 1, 2014 · 3 comments
Assignees
@ricowind
Labels
area-observatory closed-obsolete Closed as the reported issue is no longer relevant

Comments

@ricowind
Copy link
Contributor

ricowind commented Aug 1, 2014

Long storry short: for testing the ability to do pub get and pub build we copy in the packages and test them if they have a pubspec yaml file.

If you copy a symlink, like the one added in r38788, without -L to cp you will just get the relative symlink copied in, which will, of course, not work.

I generally think it is a bad idea to add symlinks to the repo, we have had enough issues with the ones for packages/pub

I will, for now, mark the test as skip in pkgbuild, but I think we should instead just add bin/runtime/vmservice to the location where we look for packages. I will make a cl for that
@ricowind
Copy link
Contributor Author

ricowind commented Aug 1, 2014

Tests skipped from r38822

@kodandersson
Copy link
Contributor

For background, the symlink was added in r38788 to enable tests in dart/tests/standalone/vmservice/* (for now, only allocations_test) to import the "observatory" package, whose source we maintain in dart/runtime/bin/vmservice/client.

If we had support for multiple pkg-root paths, an alternative would have been to add dart/runtime/bin/vmservice/client for these specific tests only (so far, there's only one, but we'll want to use this for most of them eventually).

@ricowind
Copy link
Contributor Author

ricowind commented Jun 2, 2015

Added AssumedStale label.

@ricowind ricowind added Type-Defect area-observatory closed-obsolete Closed as the reported issue is no longer relevant labels Jun 2, 2015
@ricowind ricowind self-assigned this Jun 2, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricowind ricowind

Labels
area-observatory closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricowind @kodandersson