Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mouse clicks no longer work after horizontal scrolling with middle mouse button in a custom Polymer.dart element #20275

Closed
DartBot opened this issue Jul 30, 2014 · 27 comments
Closed

Mouse clicks no longer work after horizontal scrolling with middle mouse button in a custom Polymer.dart element #20275

DartBot opened this issue Jul 30, 2014 · 27 comments
Assignees
@a-siva
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Milestone
1.16

Comments

@DartBot
Copy link

DartBot commented Jul 30, 2014

This issue was originally filed by nicomue...@gmail.com

What steps will reproduce the problem?

  1. Open custom Polymer.dart element in Dartium.
  2. Element has "overflow: auto;" as style tag.
  3. Scrolling vertical with mousewheel works fine.
  4. Scrolling horizontal with middle mouse button pressed freezes the scroll process and disables the horizontal scroll bar.
  5. Refreshing Dartium doesn't solve the issue.

Dartium version:
Chromium 36.0.1985.97 (Developer Build 282401)
OS Windows
Blink 537.36 (@­173750)
JavaScript V8 3.26.31
Dart 1.6.0-dev.5.0
Flash (Disabled)

OS:
Windows 7 - Enterprise
Service Pack 1
@kasperl
Copy link

kasperl commented Aug 18, 2014

Tentatively assigning to Siva. Looks pretty bad.

cc @vsmenon.
cc @sigmundch.
Set owner to @a-siva.
Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-Critical, C7, Accepted labels.

@DartBot
Copy link
Author

DartBot commented Aug 18, 2014

This comment was originally written by nicomuer...@gmail.com

The crash still occurs in Dartium Version 37.0.2062.0

@a-siva
Copy link
Contributor

a-siva commented Aug 18, 2014

Can you post exact instructions to reproduce the problem, i.e a sample index.html file which has the style tag referred above and contents of 'Polymer.dart'.

@DartBot
Copy link
Author

DartBot commented Aug 19, 2014

This comment was originally written by nicomuerdter...@gmail.com

I just managed to reproduce the problem. If you got a Polymer element with an overflow inside of it, it crashes. If the overflow is outside the Polymer Element there is no crash at all.

<!DOCTYPE html>

<html>
<head>
    <title>ScrollTest</title>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <script src="packages/web_components/platform.js"></script>
    <script src="packages/web_components/dart_support.js"></script>

    <script src="packages/browser/dart.js"></script>

    <script type="application/dart">import 'package:polymer/init.dart';</script>

    <link rel="import" href="packages/polymer/polymer.html">
    <polymer-element name="scroll-test" noscript>
        <template>
            <style>
                #container {
                    width: 800px;
                    height: 500px;
                    overflow: auto;
                }

                #content {
                    width: 1000px;
                    height: 1000px;
                    background-color: green;
                }
            </style>
            <div id="container">
                <div id="content">Table</div>
            </div>
        </template>
    </polymer-element>
</head>
<body>
<scroll-test></scroll-test>
</body>
</html>

@DartBot
Copy link
Author

DartBot commented Aug 19, 2014

This comment was originally written by @bgourlie

I've seen this behavior with angular.dart as well, so I don't think it's specific to polymer. It may be a shadow dom issue.

@DartBot
Copy link
Author

DartBot commented Aug 20, 2014

This comment was originally written by @bgourlie

This is definitely a Chrome bug, and not specific to Dartium. Was able to reproduce in Chrome 36 (Windows 8.1 64). Within gmail web app, I had a gchat window open and within the chat window I dragged the middle mouse button horizontally and reproduced this behavior.

@a-siva
Copy link
Contributor

a-siva commented Aug 20, 2014

Thanks for tracking that down.

Looks like this is the relevant Chrome bug that tracks this issue:
https://code.google.com/p/chromium/issues/detail?id=338604

@DartBot
Copy link
Author

DartBot commented Aug 20, 2014

This comment was originally written by @bgourlie

I don't believe that is tracking the same issue. I think a new issue needs to be submitted on the Chrome bug tracker as I couldn't find one that references the behavior found in this bug.

@terrylucas
Copy link
Contributor

BTW, this is not a crash (at least I've been unable to crash this under Release 37).

The steps to repro are:

   1. Click wheel cause scroll to happen to right-most side of horizontal scrollbar.
   2. Clicking the wheel or left button doesn't cancel horz. scroll

From this point on mouse clicks no longer works (rolling the mouse wheel will scroll the div vertically). But horz/vert scroll bars don't respond to mouse clicks in either the slider arrows or thumbs. In fact, clicking anyway where makes the appear dead (page refresh doesn't clear it up either)

I've tried this under Dartium Debug and Release builds same problem. However, if I attach Visual Studio to a running Dartium debug build then the problem doesn't occur.

Also, I've tried the same polymer file using Javascript and same problem occurs.

Here's the JS polymer code:

<!DOCTYPE html>

<html>
  <head>
    <title>ScrollTest</title>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">

    <script src="..\bower_components\platform\platform.js"></script>
    <link rel="import" href="..\bower_components\polymer\polymer.html">

    <style>
        #container {
            width: 400px;
            height: 200px;
            overflow: auto;
        }
        #content {
            width: 1000px;
            height: 1000px;
            background-color: green;
        }
    </style>
  </head>
  <body>
    <div id="container">
      <div id="content">Table</div>
    </div>
  </body>
</html>

@terrylucas
Copy link
Contributor

Forgot to mention the first step is really important

   1. Click wheel cause scroll to happen to right-most side of horizontal scrollbar.

You must move the horizontal thumb to hit the right-most side of the horizontal scrollbar. If you don't scroll all the way right then it doesn't hang and both JS and Dart polymer examples work.

@a-siva
Copy link
Contributor

a-siva commented Aug 20, 2014

Changed the title to: "Mouse clicks no longer work after horizontal scrolling with middle mouse button in a custom Polymer.dart element".

@a-siva
Copy link
Contributor

a-siva commented Aug 22, 2014

Setting milestone to 1.7 as this seems to be an upstream Chrome issue which is not fixed yet.

Removed this from the 1.6 milestone.
Added this to the 1.7 milestone.

@DartBot
Copy link
Author

DartBot commented Aug 22, 2014

This comment was originally written by @bgourlie

Is there an issue for this on the upstream bug tracker?

@kasperl
Copy link

kasperl commented Aug 25, 2014

Removed Priority-Critical label.
Added Priority-High label.

@vsmenon
Copy link
Member

vsmenon commented Aug 26, 2014

Marked this as blocking #20456.

@terrylucas
Copy link
Contributor

noticed https://code.google.com/p/chromium/issues/detail?id=338604 is still not fixed (certainly repros in 37 which is what we're shipping with in 1.7) should test in Dartium 38 or later.

Removed this from the 1.7 milestone.
Added this to the 1.8 milestone.

@DartBot
Copy link
Author

DartBot commented Sep 25, 2014

This comment was originally written by @bgourlie

The behavior described in https://code.google.com/p/chromium/issues/detail?id=338604 is not the same behavior described in this bug. I do not believe they are related.

@vsmenon
Copy link
Member

vsmenon commented Nov 12, 2014

Removed this from the 1.8 milestone.
Added this to the 1.9 milestone.

@a-siva
Copy link
Contributor

a-siva commented Feb 17, 2015

The upstream Chrome bug does not seem to have been fixed in Chrome 39 (Removing milestone 1.9, this bug is dependent on an upstream fix and a milestone can be assigned only after that).

Removed this from the 1.9 milestone.

@DartBot DartBot added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 17, 2015
@DartBot DartBot added this to the 1.11 milestone Feb 17, 2015
@kevmoo kevmoo modified the milestones: 1.12, 1.11 Jun 23, 2015
@mit-mit
Copy link
Member

mit-mit commented Aug 18, 2015

@a-siva, @kevmoo, what is the status of this (year old) bug? Does it still repro? Is it still critical? If so, what is the ETA on getting it fixed?

@kevmoo
Copy link
Member

kevmoo commented Aug 18, 2015

We may be limited to our Chrome roll. @terrylucas ?

@terrylucas
Copy link
Contributor

This has not been checked since our Chrome 39 roll. We will be rolling to
Chrome 44/45 within a month and then we can re-check this bug. My
recollection was that an earlier version of Chrome had this bug.

On Tue, Aug 18, 2015 at 8:36 AM, Kevin Moore notifications@github.com
wrote:

We may be limited to our Chrome roll. @terrylucas
https://github.com/terrylucas ?

—
Reply to this email directly or view it on GitHub
#20275 (comment).

@mit-mit
Copy link
Member

mit-mit commented Aug 19, 2015

Moving to 1.13 to to match timeline mentioned for 44/45 roll.

@mit-mit mit-mit modified the milestones: 1.13, 1.12 Aug 19, 2015
@mit-mit
Copy link
Member

mit-mit commented Oct 1, 2015

Moving to 1.14 as #24218 was moved

@mit-mit mit-mit modified the milestones: 1.14, 1.13 Oct 1, 2015
@mit-mit
Copy link
Member

mit-mit commented Jan 14, 2016

Moving again per notes in #24218

@mit-mit mit-mit modified the milestones: 1.15, 1.14 Jan 14, 2016
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@mit-mit
Copy link
Member

mit-mit commented Mar 2, 2016

Clearing out 1.15 milestone as the last full push to dev has happened. If any changes are required before 1.15 is shipped, please file a merge request

@mit-mit mit-mit modified the milestones: 1.16, 1.15 Mar 2, 2016
@terrylucas
Copy link
Contributor

New Chrome 45 rolled into Dartium 45 has the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-siva a-siva

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
1.16
Development

No branches or pull requests
7 participants
@kevmoo @terrylucas @vsmenon @kasperl @a-siva @DartBot @mit-mit