Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imm8 Disassembly slightly incorrect #19688

Closed
rakudrama opened this issue Jun 26, 2014 · 3 comments
Closed

imm8 Disassembly slightly incorrect #19688

rakudrama opened this issue Jun 26, 2014 · 3 comments
Labels
area-vm closed-not-planned Closed as we don't intend to take action on the reported issue P3 A lower priority bug or feature request

Comments

@rakudrama
Copy link
Member

Code for [Stub] Subtype3TestCache
Kind Dart
Optimized false
Function
Inclusive
Exclusive
Constant object pool
Inclusive
Exclusive
Address
Disassembly
...
0xf6b746d9 cmp edi,0xff
0xf6b746dc jz 0xf6b746e2
...

cmp edi,0xff takes 3 bytes. It must therefore be using the imm8 encoding, where 0xff is sign extended to -1, and not be comparing to 255.

It would be better if the disassembly was "cmp edi,-1"

@johnmccutchan
Copy link
Contributor

Observatory just consumes the VM's disassembler output.


Removed Area-Observatory label.
Added Area-VM label.
Changed the title to: "imm8 Disassembly slightly incorrect".

@iposva-google
Copy link
Contributor

Removed Priority-Unassigned label.
Added Priority-Low label.

@iposva-google
Copy link
Contributor

Added NotPlanned label.

@rakudrama rakudrama added Type-Defect P3 A lower priority bug or feature request area-vm closed-not-planned Closed as we don't intend to take action on the reported issue labels Jan 9, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm closed-not-planned Closed as we don't intend to take action on the reported issue P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

3 participants