"Find uses" filters inaccessible matches too aggressively #19660
Comments
|
Digging through the editor source code a little, the culprit seems to be the call to HierarchyUtils.getAccessibleMatches() from within FindReferencesAction. It filters out f as a search result because test1.dart doesn't import test2.dart. But that's irrelevant, since it's not necessary to import test2.dart in order to call B.foo()--all you need is to have access to an object of type B. |
|
Set owner to @scheglov. |
|
Removed this from the 1.6 milestone. |
|
Removed Oldschool-Milestone-1.6 label. |
|
After review, we believe we can better address this issue by helping editors like sublime and webstorm provide great Dart support. Added NotPlanned label. |
|
This issue is still valid for the server, so should be triaged in context of the server later. Removed Area-Editor label. |
|
Actually it seems that in the Analysis Server we have an implementation that does not have this issue. Attachment: Added AssumedStale label. |
stereotype441
added
Type-Defect
area-analyzer
Given the following sources:
test1.dart:
class A {
foo() {}
}
f(A a) {
a.foo();
}
test2.dart:
import 'test1.dart';
class B extends A {
@override
foo();
}
main() {
f(new B());
}
Selecting B.foo and using the editor's "find uses" feature produces 0 search results. This is incorrect: f calls A.foo, and this is a valid match because B.foo overrides A.foo.
If the line "import 'test2.dart';" is added to the top of test1.dart, then the search works properly. This should not be necessary to get proper search results (in fact, editor correctly shows a hint indicating that this is an unused import).
The text was updated successfully, but these errors were encountered: