Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: missing values from enclosing activations #19577

Closed
rmacnak-google opened this issue Jun 20, 2014 · 5 comments
Closed

Editor: missing values from enclosing activations #19577

rmacnak-google opened this issue Jun 20, 2014 · 5 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug

Comments

@rmacnak-google
Copy link
Contributor

When paused at the throw, I expect the display for the activation of the inner to display the receiver and the locals. E.g., Foo.inner() should display this, x, y, and z.

In less trivial examples the activations of inner and outer can be far apart on the stack--and may be separated by other activations of the same functions with different enclosing contexts or different receivers--making it difficult to find the values of variables in the context one is looking at.

class Foo extends Super {
  foo() {
    var x = 1;
    outer() {
       var y = 2;
       inner() {
         var z = 3;
         throw "x";
       }
       inner();
    }
    outer();
  }
}

@clayberg
Copy link

Set owner to @devoncarew.
Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@devoncarew
Copy link
Member

I don't believe these variables are captured currently - it would take a change to the VM to accommodate this. Re-assigning to the VM team.


Removed the owner.
Removed Editor-Debugging label.
Added Area-VM label.

@DartBot
Copy link

DartBot commented Jan 5, 2015

This comment was originally written by @mhausner


This is the same issue as 20047. I added some background to that bug, so closing this as duplicate.

The short story is: it's unlikely that we start capturing variables that are not used in inner functions (closures). That's a real runtime cost which is not justified.


Added Duplicate label.
Marked as being merged into #20047.

@rmacnak-google rmacnak-google added Type-Enhancement area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report labels Jan 5, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

6 participants