Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub run should support passing in flags to vm #19569

Closed
keertip opened this issue Jun 19, 2014 · 11 comments
Closed

Pub run should support passing in flags to vm #19569

keertip opened this issue Jun 19, 2014 · 11 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@keertip
Copy link
Contributor

keertip commented Jun 19, 2014

A typical invocation of the vm to run command line apps from DartEditor would look like

dart --enable-checked-mode --debug:50677 --enable-vm-service:50678 --trace_service_pause_events --pause-isolates-on-start myapp.dart

and any other that the user may specify

DartEditor should be able to specify arguments to pass on to the vm when starting pub run from the editor.

@munificent
Copy link
Member

Relatively soon, I want pub run to change from spawning a process to spawning an isolate for the entrypoint being run. (See: https://code.google.com/p/dart/issues/detail?id=19438).

If that happens, we wouldn't be able to have separate VM flags for the spawned app. Would it make sense to spawn the pub process itself with these settings? That would mean the user is also implicitly debugging pub. This could be good if they want to see what transformers are doing, but may be confusing otherwise.

What do you think?


cc @nex3.
Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-High labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Added this to the 1.6 milestone.

@munificent
Copy link
Member

Removed this from the 1.6 milestone.
Removed Priority-High label.
Added Priority-Medium label.

@nicolasgarnier
Copy link
Contributor

I would also need this for the test runner to be able to gather code coverage data from tests.

I guess that would still be OK with isolates though just a bit more handling/filtering to do.

@sethladd
Copy link
Contributor

sethladd commented Dec 9, 2014

Does the test runner run via pub run? Is that why you need it?

@nicolasgarnier
Copy link
Contributor

The test runner runs Standalone VM test (aka non Browser tests) using "pub run" and browser tests using "pub serve" that allows us to make sure eventual transformers are applied without having to run "pub build" first.

@nicolasgarnier
Copy link
Contributor

By the way it would be great if we could also have "pub run" run the VM in un-checked mode (currently it always runs in checked mode). I'm asking about that here because it seem related (you could just make that a flag you optionally pass to the underlying VM)

@nex3
Copy link
Member

nex3 commented Dec 9, 2014

When we add support for this, we'll definitely allow explicit control of checked mode as well.

@sethladd
Copy link
Contributor

Possibly blocked by https://code.google.com/p/dart/issues/detail?id=21791 ?

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#1018.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

8 participants