Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename file with dart extension to no extension does not complete #19533

Closed
keertip opened this issue Jun 18, 2014 · 10 comments
Closed

Rename file with dart extension to no extension does not complete #19533

keertip opened this issue Jun 18, 2014 · 10 comments
Assignees
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Milestone

Comments

@keertip
Copy link
Contributor

keertip commented Jun 18, 2014

Trying to rename a file BUILD.dart to BUILD, rename does not complete. Analysis kicks off, the rename dialog shows up, but do not wait for analysis does nothing.

Have to go to terminal and rename.

@scheglov
Copy link
Contributor

I just tried it on a "big Angular project".
Works for me.

  1. "Do It Now" button works for me.

  2. Analysis DOES complete after some time.


    Added CannotReproduce label.

@clayberg
Copy link

WHy does Analysis need any time at all to do this? Renaming an empty BUILD.dart file to BUILD should be a nearly instantaneous operation.

@scheglov
Copy link
Contributor

AnalysisContextImpl invalidates everything when any new Dart source is added.

The reason is because it might have been referenced (and not found) by some libraries, and now these libraries may be resolved. There is TODO about this.


cc @bwilkerson.

@clayberg
Copy link

Can we optimize the empty file case at least?
Should AnalysisContextImpl be invalidated when the .dart file is empty?
The use case described in this issue (e.g., creating a new empty file and then immediately renaming it) seems to be something we should handle better.
Also, maybe we should special case new file creation so that BUILD does not become BUILD.dart to begin with.


Added NeedsInfo label.

@keertip
Copy link
Contributor Author

keertip commented Jun 19, 2014

Fix for BUILD remaining just BUILD - https://codereview.chromium.org/344033003/

@scheglov
Copy link
Contributor

Set owner to @bwilkerson.
Removed Area-Editor label.
Added Area-Analyzer label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@bwilkerson
Copy link
Member

This is certainly working now.


Added Fixed label.

@clayberg
Copy link

Added this to the 1.8 milestone.

@keertip keertip added Type-Defect area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 28, 2014
@keertip keertip added this to the 1.8 milestone Nov 28, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Development

No branches or pull requests

5 participants