New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename file with dart extension to no extension does not complete #19533
Comments
I just tried it on a "big Angular project".
|
WHy does Analysis need any time at all to do this? Renaming an empty BUILD.dart file to BUILD should be a nearly instantaneous operation. |
AnalysisContextImpl invalidates everything when any new Dart source is added. The reason is because it might have been referenced (and not found) by some libraries, and now these libraries may be resolved. There is TODO about this. cc @bwilkerson. |
Can we optimize the empty file case at least? Added NeedsInfo label. |
Fix for BUILD remaining just BUILD - https://codereview.chromium.org/344033003/ |
Set owner to @bwilkerson. |
Removed this from the 1.6 milestone. |
Removed Oldschool-Milestone-1.6 label. |
This is certainly working now. Added Fixed label. |
Added this to the 1.8 milestone. |
Trying to rename a file BUILD.dart to BUILD, rename does not complete. Analysis kicks off, the rename dialog shows up, but do not wait for analysis does nothing.
Have to go to terminal and rename.
The text was updated successfully, but these errors were encountered: