New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pub build packages directory for a Polymer app is too big #19521
Comments
Added Triaged label. |
Short term question: Can I safely delete one of the copies of each? |
That's a good point. We could remove the *.concat.js versions in release mode. The main challenge is how. I can imagine 2 options: As for your question in #2, yes. You can safely delete the *.concat.js files and the .map files after you build in release mode. |
Thanks Siggi! Removing the *.concat.js files reduced the compiled Observatory size by 0.5MB (or 25%). We were already removing the *.map files. |
Added this to the 1.6 milestone. |
Removed this from the 1.6 milestone. |
Removed Polymer-P-1 label. |
Added PolymerMilestone-Next label. |
Removed Polymer-Milestone-Next label. |
Added this to the 1.6 milestone. |
Removed this from the 1.6 milestone. |
Marked this as being blocked by #18489. |
Added this to the 1.6 milestone. |
Removed this from the 1.6 milestone. |
I am going to see how I can clean this up without the global transformer, if nothing else by making the packages that we own perform some cleanup on themselves. |
We already do the cleanup ourselves- this bug was opened in the hope that we can stop doing that. |
The change I am looking at making would remove the need for you to do any manual cleanup. Specifically I am implementing option #1 that was discussed earlier (adding a transformer to the web_components package). |
Also I am fixing some of the existing cleanup steps that are not functioning properly (for the polymer package) |
r39828 submitted, will work on doing the same thing for web_components. I will still leave this issue open though as there is much more we could potentially do given a global transformer. |
This issue has been moved to dart-archive/polymer-dart#405. |
Reproduction steps:
$ cd runtime/bin/vmservice/client
$ pub build --mode=release
Look in build/web/packages
Specifically,
824K ./packages/polymer/src/js/polymer
That directory has two copies of polymer.js (polymer.js and polymer.concat.js). It also has two map files.
1.6M ./packages/web_components
Same problem here, directory has two copies of platform.js (platform.js and platform.concat.js). It also has two map files (each are half a meg in size!).
I'm not sure why .map files are being included in release mode build output.
The text was updated successfully, but these errors were encountered: