Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DartEditor needs to bring back being able to view getter properties #19506

Closed
DartBot opened this issue Jun 17, 2014 · 12 comments
Closed

DartEditor needs to bring back being able to view getter properties #19506

DartBot opened this issue Jun 17, 2014 · 12 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 17, 2014

This issue was originally filed by ir...@google.com


What steps will reproduce the problem?

  1. Create a class with a bunch of getters and setters.
  2. Debug it to see the value of a getter

What is the expected output? What do you see instead?
Debugger should show the getter values
Debugger does not show any value that is a method call.

What version of the product are you using? On what operating system?

Please provide any additional information below.
I understand why this might be done but can we add a checkbox or an option/preferences to enable seeing the value of getters much like it was a few weeks ago.

C1

@lrhn
Copy link
Member

lrhn commented Jun 18, 2014

I'd be very wary of letting the debugger run code automatically. Getters can have side effects, and you have no way to control how often the debugger will call it.

I'd recommend just showing '<getter>' or something, and then let the user click/rightclick/whatever and choose to get the value.


Removed Type-Defect label.
Added Type-Enhancement, Area-Editor, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Jun 18, 2014

This comment was originally written by @zoechi


Usually it's bad style to have getters with side effects. I think this is similar to toString() which has a configuration setting in DartEditor.

My preferred solution is:

  • a setting like the one for toString
  • and an annotation to disable calling by the debugger for individual getters

@clayberg
Copy link

Set owner to @devoncarew.
Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@devoncarew
Copy link
Member

Jacob, I don't see getters being returned as properties anymore. Is this a deliberate change?


cc @jacob314.

@jacob314
Copy link
Member

Getters are still there but are now exposed with the correct json allowing you to call getters and setters. Look under the [[class]] field.

The correct chrome devtools protocol information is now exposed for getter and setter properties so you will now be able to get them 1 at a time rather than all at once.

@devoncarew
Copy link
Member

Issue #19481 has been merged into this issue.

@devoncarew
Copy link
Member

OK, I see them in the protocol now, with the accessorPropertiesOnly flag into Runtime.getProperties. It will take some refactoring to make them visible in the editor.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@sethladd
Copy link
Contributor

Added Editor-Debugging label.

@clayberg
Copy link

cc @scheglov.

@DartBot
Copy link
Author

DartBot commented Aug 6, 2015

This issue has been moved to dart-archive/eclipse3#25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

8 participants