New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DartEditor needs to bring back being able to view getter properties #19506
Comments
I'd be very wary of letting the debugger run code automatically. Getters can have side effects, and you have no way to control how often the debugger will call it. I'd recommend just showing '<getter>' or something, and then let the user click/rightclick/whatever and choose to get the value. Removed Type-Defect label. |
This comment was originally written by @zoechi Usually it's bad style to have getters with side effects. I think this is similar to My preferred solution is:
|
Set owner to @devoncarew. |
Jacob, I don't see getters being returned as properties anymore. Is this a deliberate change? cc @jacob314. |
Getters are still there but are now exposed with the correct json allowing you to call getters and setters. Look under the [[class]] field. The correct chrome devtools protocol information is now exposed for getter and setter properties so you will now be able to get them 1 at a time rather than all at once. |
Issue #19481 has been merged into this issue. |
OK, I see them in the protocol now, with the accessorPropertiesOnly flag into Runtime.getProperties. It will take some refactoring to make them visible in the editor. |
Removed this from the Later milestone. |
Removed Oldschool-Milestone-Later label. |
Added Editor-Debugging label. |
cc @scheglov. |
This issue has been moved to dart-archive/eclipse3#25. |
This issue was originally filed by ir...@google.com
What steps will reproduce the problem?
What is the expected output? What do you see instead?
Debugger should show the getter values
Debugger does not show any value that is a method call.
What version of the product are you using? On what operating system?
Please provide any additional information below.
I understand why this might be done but can we add a checkbox or an option/preferences to enable seeing the value of getters much like it was a few weeks ago.
C1
The text was updated successfully, but these errors were encountered: