Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[smoke] compareList(unordered: true) is broken #19471

Closed
DartBot opened this issue Jun 16, 2014 · 9 comments
Closed

[smoke] compareList(unordered: true) is broken #19471

DartBot opened this issue Jun 16, 2014 · 9 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@DartBot
Copy link

DartBot commented Jun 16, 2014

This issue was originally filed by @vicb

The unordered comparison is broken in common.dart:

    var bSet = new Set()..addAll(b);
    for (int i = 0; i < a.length; i++) {
      if (!bSet.contains(a[i])) return false;
    }

if a=[1, 1, 1] and b = [1, 2, 3] it will return true.
@kasperl
Copy link

kasperl commented Jun 17, 2014

Added Area-Pkg, Pkg-Smoke, Triaged labels.

@sigmundch
Copy link
Member

fix out for review https://codereview.chromium.org/370493002/

Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@sigmundch
Copy link
Member

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Next label.

@DartBot
Copy link
Author

DartBot commented Jul 13, 2014

This comment was originally written by @vicb

Seems like the code is still broken (I've left a comment in the review)

@sigmundch
Copy link
Member

Added Fixed label.

@DartBot DartBot added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Apr 1, 2015
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/smoke#12.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sigmundch @kasperl @DartBot