Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The todomvc sample needs work #19394

Closed
stevemessick opened this issue Jun 12, 2014 · 9 comments
Closed

The todomvc sample needs work #19394

stevemessick opened this issue Jun 12, 2014 · 9 comments
Labels
area-samples (deprecated) Deprecated: this label is no longer actively used. closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@stevemessick
Copy link
Contributor

It seems that build.dart files are not used anymore (please correct me if I'm wrong).
This means they should be removes from samples (todomvc) and the create polymer project template.
In addition todomvc reports the following errors:

ShadowRoot.resetStyleInheritance and ShadowRoot.applyAuthorStyles now deprecated in dart:html.
Please remove them from your code.
 (:1)

What is "(:1)" BTW?

//Lars
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.5.0.dev_04_07 (2014-06-11)
OS: Windows 8 - amd64 (6.2)
JVM: 1.7.0_51

projects: 3

open dart files: 2

auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 1778 / 1040 / 446 MB
thread count: 33
index: 1422092 relationships in 210639 keys in 707 sources

SDK installed: true
Dartium installed: true
@stevemessick
Copy link
Contributor Author

Attachment:
screenshot.png (82.57 KB)

@dgrove
Copy link
Contributor

dgrove commented Jun 12, 2014

This warning will go away with polymer 0.11.0, coming very soon: ShadowRoot.resetStyleInheritance and ShadowRoot.applyAuthorStyles now deprecated in dart:html.
Please remove them from your code.
 (:1)
 

cc @sigmundch.

@sigmundch
Copy link
Member

As for 'build.dart', it is still in use. Right now it is used just for linting and showing warnings in the editor. There are plans to remove it by using pub-serve for this instead, but there is still work to be done in the editor-pub integration to make that happen.

@kasperl
Copy link

kasperl commented Jun 12, 2014

What's the priority of this and who is the owner? What do we expect to do about this for 1.5?

cc @dgrove.
cc @sigmundch.
cc @jmesserly.

@kasperl
Copy link

kasperl commented Jun 12, 2014

I'm pretty sure I tried putting a 'throw 42' into build.dart and things still worked. Can someone investigate this?

@kasperl
Copy link

kasperl commented Jun 13, 2014

Looks like I was wrong. If I change a file after messing with build.dart, it does throw. Moving this issue to 1.6 as the polymer warnings are going to be addressed with issue #19419 (still on target for 1.5).

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@sigmundch
Copy link
Member

The fix for the warning is now submitted. Merge request is here: https://code.google.com/p/dart/issues/detail?id=19452

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@stevemessick stevemessick added Type-Defect area-samples (deprecated) Deprecated: this label is no longer actively used. labels Aug 4, 2014
@kasperl kasperl mentioned this issue Jun 3, 2015
Closed
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Mar 1, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-samples (deprecated) Deprecated: this label is no longer actively used. closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @matanlurey @sigmundch @dgrove @kasperl @stevemessick