Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide a way to update AnalysisContext in code_transformer package #19275

Closed
DartBot opened this issue Jun 6, 2014 · 7 comments
Closed

provide a way to update AnalysisContext in code_transformer package #19275

DartBot opened this issue Jun 6, 2014 · 7 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 6, 2014

This issue was originally filed by @a14n

In my zengen package I make modifications on the dart sources through pub transformers. A modification is done based on a resolved AST. Some modifications lead to other modifications that need an up-to-date AST with previous modifications.

To have this AST up to date the only solution I found was to emit the output Asset and reapply the same transformer. And redo this as long as there are code transformations done.

To avoid this recursivity (and perhaps optimize analysis) it would be worth to provide a method like Resolver.applyTextEditTransaction(xxx) (that would call the underlying analysisContext.applyChanges).
@iposva-google
Copy link
Contributor

Added Pkg-CodeTransformers, Area-Pkg, Triaged labels.

@sigmundch
Copy link
Member

Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@sigmundch
Copy link
Member

Added Polymer-P-2 label.

@sigmundch
Copy link
Member

Removed this from the Later milestone.

@sigmundch
Copy link
Member

Removed Polymer-P-2 label.
Added Polymer-Milestone-Later label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Later label.
Added PolymerMilestone-Later label.

@DartBot DartBot added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jul 9, 2014
@DartBot DartBot mentioned this issue Jun 5, 2015
Open
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/code_transformers#19.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @sigmundch @iposva-google @DartBot