New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bad generics substitution in analyzer package with type.substitute4 #19253
Comments
Added Area-Analyzer, Triaged labels. |
Added this to the 1.6 milestone. |
Set owner to collinsn@google.com. |
Removed this from the 1.6 milestone. |
Removed Oldschool-Milestone-1.6 label. |
This comment was originally written by collinsn@google.com My internship is ending today. Set owner to @bwilkerson. |
Added Started label. |
I know how to change the behavior of the method, but doing so would incur a performance penalty. Given that it's been 5 months since the issue was filed (sorry about that!), I'm guessing that the fix is no longer needed. I have therefore updated the doc comment for the method to indicate the state of the implementation. Please reopen the issue if the current implementation is still causing you problems. |
This comment was originally written by @a14n I took some times to remember where I wanted to use it :) But finally I found it in zengen. Here is the workaround I have used. // final newType = type.substitute4(argumentsTypes); What do you think ? |
Given that what you want is to completely replace the list of arguments, I think that's a fine solution. Another possibility, which isn't necessarily any better would be: Added NotPlanned label. |
This comment was originally written by @a14n Thanks for your advices. |
Added this to the 1.8 milestone. |
This issue was originally filed by @a14n
In analyzer-0.13.5 (and also in 0.15.5) calling
r = type.substitute4(argumentsTypes)
doesn't return the expected DartType for :type=Iterable<Iterable<E>>
argumentsTypes=[Iterable<String>]
r=Iterable<Iterable<E>>
For this case r should be
Iterable<Iterable<String>>
.However it works with simplier parameters :
type=Iterable<E>
argumentsTypes=[String]
r=Iterable<String>
The text was updated successfully, but these errors were encountered: