Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub serve delay between "Serving..." and "Build completed" #19150

Closed
dgrove opened this issue Jun 3, 2014 · 14 comments
Closed

pub serve delay between "Serving..." and "Build completed" #19150

dgrove opened this issue Jun 3, 2014 · 14 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@dgrove
Copy link
Contributor

dgrove commented Jun 3, 2014

Running with tip of bleeding_edge, I'm seeing a delay of 6-7 seconds between the time that pub serve prints "Serving todomvc web on http://127.0.0.1:8080" and the time that it prints "Build completed successfully".

This is when running the TodoMVC sample in Dartium

@nex3
Copy link
Member

nex3 commented Jun 3, 2014

This sounds like time being spent running the polymer transformers. Siggi, could they take 6-7s worth of time?


cc @sigmundch.

@sigmundch
Copy link
Member

It could - when do you pub-build pub reports about 5-6 seconds running polymer on TodoMVC. Most of the time is running the resolver (which might be loading and analyzing the entire SDK).

I haven't tried, but we could provide a mock SDK to the analyzer that only contains what we need. But the analyzer might already have this planned.

@nex3
Copy link
Member

nex3 commented Jun 3, 2014

A bit of barback instrumenting seems to confirm this: running ScriptCompactor on web/index.html takes about 5.6s on my machine. I'll bump this over to polymer.


cc @munificent.
Set owner to @sigmundch.
Removed Area-Pub label.
Added Area-Pkg, Pkg-Polymer labels.

@sigmundch
Copy link
Member

For now, I'm going to investigate making the build faster with a mock SDK for the analyzer as a temporary workaround, but long term, I believe we should invest in a solution that allow us to not run transformations when launching an app for development in Dartium.

Bob and I had a long brainstorming discussion this morning about what we could do to address this, but it requires non-trivial changes. For example, one attractive idea we had was to use the user-agent to decide how transformers are run, similar to namespaces ideas you had discussed in the past.

@sigmundch
Copy link
Member

FYI - here is a change that let us mock out the SDK. It's an improvement, but it's not perfect:

https://codereview.chromium.org/315813003/

It takes TodoMVC from 4.8s in my machine, to 2.7s. The analyzer still resolves the entire application. I could make mocks for parts of the libraries that are known to us (like polymer), but I'm not sure about that. It already feels brittle with the current change.

The ultimate solution is to be lazy and not run any of the transformers in TodoMVC.

See: issue #19168

@dgrove
Copy link
Contributor Author

dgrove commented Jun 5, 2014

This is significantly improved by polymer 0.10.1 . There's still more to do, but we're in good shape for 1.5 .


Removed this from the 1.5 milestone.
Removed Priority-High label.
Added Priority-Medium label.

@sigmundch
Copy link
Member

Added this to the Later milestone.

@sigmundch
Copy link
Member

Removed this from the Later milestone.
Added this to the 1.6 milestone.

@sigmundch
Copy link
Member

Removed this from the 1.6 milestone.
Added this to the Later milestone.

@sigmundch
Copy link
Member

Added Polymer-P-2 label.

@sigmundch
Copy link
Member

Removed this from the Later milestone.

@sigmundch
Copy link
Member

Removed Polymer-P-2 label.
Added Polymer-Milestone-Later label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Later label.
Added PolymerMilestone-Later label.

@dgrove dgrove added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jul 9, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#201.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Development

No branches or pull requests

5 participants