Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming class in library within a project does not modify instantiations of class in files that import library #19072

Closed
DartBot opened this issue May 29, 2014 · 9 comments
Closed

Renaming class in library within a project does not modify instantiations of class in files that import library #19072

DartBot opened this issue May 29, 2014 · 9 comments
Assignees
@bwilkerson
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Milestone
1.8

Comments

@DartBot
Copy link

DartBot commented May 29, 2014

This issue was originally filed by argentiappa...@gmail.com

In lib/lib.dart:

  library lib;

  class Something {
  }

in bin/test.dart:

  import 'package:test/lib.dart';

  void main() {
    var s = new Something();
  }

Upon renaming class Something, the instantiation in test.dart is not modified.

Dart Editor version 1.3.6.release (STABLE) on Windows 7 SP1.

Attachment:
renameclass.png (95.24 KB)
@DartBot
Copy link
Author

DartBot commented May 29, 2014

This comment was originally written by argentiappara...@gmail.com

Better screenshot

Attachment:
renameclass.png (106.70 KB)

@sethladd
Copy link
Contributor

sethladd commented Jun 2, 2014

Added Area-Editor, Triaged labels.

@clayberg
Copy link

clayberg commented Jun 2, 2014

Set owner to @scheglov.
Added this to the 1.5 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@scheglov
Copy link
Contributor

scheglov commented Jun 3, 2014

Interesting.
If I create a project from scratch and set bin/test.dart source before lib/lib.dart, then refactoring does not update bin/test.dart file.

See screen shots.

  1. After filling lib/lib.dart error in bin/test.dart does not go away.
  2. After saving lib.lib.dart errors does disappears, but bin/test.dart is not indexed. Changes in lib/lib.dart don't cause bin/test.dart indexing.

After changing bin/test.dart it starts indexing and renaming again.

cc @danrubel.
Set owner to @bwilkerson.
Removed Area-Editor label.
Added Area-Analyzer label.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@bwilkerson
Copy link
Member

This appears to be working correctly, regardless of the order in which the files are opened.

Added Fixed label.

@clayberg
Copy link

Added this to the 1.8 milestone.

@DartBot DartBot added Type-Defect area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 28, 2014
@DartBot DartBot added this to the 1.8 milestone Nov 28, 2014
@DartBot DartBot mentioned this issue Jun 4, 2015
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
6 participants
@sethladd @scheglov @kasperl @bwilkerson @clayberg @DartBot