Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data binding doesn't work if binding contains reserved word in Dart #19069

Closed
jmesserly opened this issue May 29, 2014 · 11 comments
Closed

data binding doesn't work if binding contains reserved word in Dart #19069

jmesserly opened this issue May 29, 2014 · 11 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@jmesserly
Copy link

we'll need to figure out something so we can bind to JS props with those names...

perhaps a name mangling scheme or something else. it is primarily a concern because of interop -- otherwise would be fine to not support them.

https://codereview.chromium.org/303003003/diff/20001/pkg/polymer/test/build/script_compactor_test.dart?column_width=80
@jmesserly
Copy link
Author

Removed Area-Polymer label.
Added Area-Pkg, Pkg-PolymerExpressions labels.

@jmesserly
Copy link
Author

Removed Library-PolymerExpressions label.

@justinfagnani
Copy link
Contributor

I don't think this is a big deal. JS interop works via String names right now, and when we have Dart interfaces for them they won't be able to use reserved words as property names, so any translation will have to happen there.

If we want to add special support for dart:js.JsObject in PolymerExpressions we can still only create new Symbol objects after we determine the receiver is just a plain Dart object.

@sigmundch
Copy link
Member

ok - this still needs to be fixed in the codegen. Script_compactor shouldn't generate getters for these keywords.

Added this to the 1.6 milestone.
Removed Priority-Unassigned, Pkg-PolymerExpressions labels.
Added Priority-Medium, Pkg-PolymerBuild labels.

@sigmundch
Copy link
Member

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Next label.

@jmesserly jmesserly added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jul 9, 2014
@jmesserly
Copy link
Author

@jakemac53 ... this might get fixed in new polymer?

@jakemac53
Copy link
Contributor

We still are using smoke to read properties (at least for now), so I think this is still an issue.

@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#398.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @justinfagnani @jakemac53 @jmesserly @sigmundch @DartBot