Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackoverflow in factory constructor causes Dartium to crash #19028

Closed
DartBot opened this issue May 27, 2014 · 10 comments
Closed

Stackoverflow in factory constructor causes Dartium to crash #19028

DartBot opened this issue May 27, 2014 · 10 comments
Assignees
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented May 27, 2014

This issue was originally filed by greg.l...@gmail.com


Running the following code causes the editor to hang, I expect the editor to show a StackOverflow error instead.

Also when running this code on the command line, no stack trace is given.

class Foo {
  factory Foo.boom() => new Foo.boom();
}

main() {
  new Foo.boom();
}

@lrhn
Copy link
Member

lrhn commented May 27, 2014

I don't believe the VM ever prints stack traces on uncaught stack overflows.


Added Area-Editor, Triaged labels.

@clayberg
Copy link

cc @keertip.
Set owner to @devoncarew.
Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@DartBot
Copy link
Author

DartBot commented May 27, 2014

This comment was originally written by greg....@gmail.com


@LRN - right - I guess the stack trace would be too big to print.

It would be useful to get a trace of the bottom of the stack - so that at least you could see where the recursion began. I wonder what Java/C# do.

Shall I open another bug for this?

@devoncarew
Copy link
Member

I'm splitting this into two bugs. I see Dartium crashing on this, and the command-line VM sending us never-ending stack frames.

So for Dartium, when I run the above example I see an immediate Dartium crash, and get back a 'Inspector.targetCrashed' over the debug protocol.


Set owner to @jacob314.
Removed Area-Editor label.
Added Area-Dartium label.

@devoncarew
Copy link
Member

Filed the VM issues as 19070.


Changed the title to: "Stackoverflow in factory constructor causes Dartium to crash".

@vsmenon
Copy link
Member

vsmenon commented Jun 4, 2014

Added Dartium-Crasher label.

@vsmenon
Copy link
Member

vsmenon commented Jun 4, 2014

Removed this from the Later milestone.
Added this to the 1.5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

9 participants