Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack trace output lines in DartEditor aren't hyperlinks to the source anymore #18981

Closed
DartBot opened this issue May 23, 2014 · 9 comments
Closed

Stack trace output lines in DartEditor aren't hyperlinks to the source anymore #18981

DartBot opened this issue May 23, 2014 · 9 comments
Assignees
@keertip
Milestone
1.9

Comments

@DartBot
Copy link

DartBot commented May 23, 2014

This issue was originally filed by @zoechi

What steps will reproduce the problem?
1.
Run an app (I run with Dartium)
The output

/home/zoechi/source/3rdparty/google/darteditor/chromium/chrome --remote-debugging-port=42396 --user-data-dir=/home/zoechi/.dartium --enable-experimental-web-platform-features --enable-html-imports --no-first-run --no-default-browser-check --no-process-singleton-dialog chrome://version/
ShadowRoot.resetStyleInheritance is now deprecated in dart:html.
Please remove from your code.
 (:1)
type 'DivElement' is not a subtype of type 'BwuDatagrid' of 'value'.

­0 AppElement.grid= (http://127.0.0.1:8081/src/totals_via_data_provider/app_element.dart:70:15)

­1 AppElement.attached (http://127.0.0.1:8081/src/totals_via_data_provider/app_element.dart:99:7)

­2 Native_Utils_register (dart:_blink:8327)

­3 _Utils._register (dart:html:37823)

­4 _Utils.register (dart:html:37819)

­5 HtmlDocument.registerElement (dart:html:14673)

­6 HtmlDocument.register (dart:html:14680)

­7 PolymerDeclaration.registerType (package:polymer/src/declaration.dart:163:22)

­8 PolymerDeclaration.register (package:polymer/src/declaration.dart:81:17)

­9 _hookJsPolymer.registerDart.<anonymous closure> (package:polymer/src/loader.dart:100:75)

­10 _rootRun (dart:async/zone.dart:719)

­11 _RootZone.run (dart:async/zone.dart:862)

­12 _hookJsPolymer.registerDart (package:polymer/src/loader.dart:99:22)

­13 JsFunction.apply (dart:js:254)

­14 Polymer.register (package:polymer/src/instance.dart:79:48)

­15 main.<anonymous closure> (http://127.0.0.1:8081/totals_via_data_provider.html_bootstrap.dart:64:29)

­16 startPolymer (package:polymer/src/loader.dart:53:16)

­17 main (http://127.0.0.1:8081/totals_via_data_provider.html_bootstrap.dart:59:15)

 (:1)

2.
only lines with source references starting with 'package' are shown as links
but many are not (starting with 'http://' or 'dart:')

­0 AppElement.grid= (http://127.0.0.1:8081/src/totals_via_data_provider/app_element.dart:70:15)

­1 AppElement.attached (http://127.0.0.1:8081/src/totals_via_data_provider/app_element.dart:99:7)

­2 Native_Utils_register (dart:_blink:8327)

­3 _Utils._register (dart:html:37823)

­4 _Utils.register (dart:html:37819)

­5 HtmlDocument.registerElement (dart:html:14673)

­6 HtmlDocument.register (dart:html:14680)

3.

What is the expected output? What do you see instead?
should be hyperlinks to the source file/line

What version of the product are you using? On what operating system?
Dart VM version: 1.5.0-dev.1.1 (Thu May 22 23:40:13 2014) on "linux_x64"

Please provide any additional information below.
started with the most recent update. Seems to come from running with 'pub serve'
@anders-sandholm
Copy link
Contributor

Not clear to me if VM, Editor or Pub issue.
Let's fix it anyhow!

Added Area-Editor, Triaged labels.

@clayberg
Copy link

cc @keertip.
Set owner to @devoncarew.
Added this to the 1.5 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@devoncarew
Copy link
Member

Re-assigning to Keerti - it's likely that this is a regression due to pub serve.

Set owner to @keertip.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@DartBot
Copy link
Author

DartBot commented Aug 21, 2014

This comment was originally written by @zoechi

Exception: Uncaught Error: type 'List<ItemBase>' is not a subtype of type 'List<MapDataItem>' of 'left'.
Stack Trace:
#­0 moveRowsHandler (http://localhost:8080/src/e09_row_reordering/app_element.dart:161:55)
#­1 _RootZone.runUnaryGuarded (dart:async/zone.dart:1020)
#­2 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341)
#­3 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:270)
#­4 _SyncBroadcastStreamController._sendData (dart:async/broadcast_stream_controller.dart:346)
#­5 _BroadcastStreamController.add (dart:async/broadcast_stream_controller.dart:237)
#­6 EventBus.fire (package:bwu_datagrid/core/event_bus.dart:61:19)
#­7 _handleDragEnd (package:bwu_datagrid/plugins/row_move_manager.dart:143:20)
#­8 _RootZone.runUnaryGuarded (dart:async/zone.dart:1020)
#­9 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341)
#­10 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:270)
#­11 _SyncBroadcastStreamController._sendData (dart:async/broadcast_stream_controller.dart:346)
#­12 _BroadcastStreamController.add (dart:async/broadcast_stream_controller.dart:237)
#­13 EventBus.fire (package:bwu_datagrid/core/event_bus.dart:61:19)
#­14 _handleDragEnd (package:bwu_datagrid/bwu_datagrid.dart:2543:19)

This is still an issue

line #­6, #­7, #­13, #­14 (starting with 'package:') are links and they work fine

but #­0 (starting with 'http://localhost:8080/ still isn't (the most relevant in this case)

@keertip
Copy link
Contributor

keertip commented Feb 3, 2015

https://codereview.chromium.org/888643002/

Added Fixed label.

@clayberg
Copy link

Added this to the 1.9 milestone.

@DartBot DartBot added this to the 1.9 milestone Mar 25, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keertip keertip

Labels
None yet
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
6 participants
@devoncarew @kasperl @keertip @anders-sandholm @clayberg @DartBot