Analyzer not warning when overriding method does not include the same default values #18914
Assignees
Labels
analyzer-test
area-analyzer
Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Milestone
Comments
|
The test now passes on dartanalyzer, but still fails on dart2analyzer. What is the status of this bug? |
|
I don't know why the test is passing, but analyzer still does not produce a warning for the code sample above, so the issue is not fixed. |
|
Removed this from the 1.6 milestone. |
|
Removed Oldschool-Milestone-1.6 label. |
|
Set owner to @stereotype441. |
|
Fix sent out for review: https://codereview.chromium.org/700923002/ |
|
Fixed in revision 41503. Added Fixed label. |
|
Added this to the 1.8 milestone. |
bwilkerson
added
Type-Defect
area-analyzer
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Section of the specification states:
It is a static warning if an instance method m1 overrides an instance member m2, the signature of m2 explicitly specifies a default value for a formal parameter p and the signature of m1 specifies a different default value for p.
But the following code produces no warning:
class A {
foo([x = 1]) {}
}
class B extends A {
foo([x]) {}
}
This is causing the co19 test Language/07_Classes/4_Abstract_Instance_Members_A07_t02 to fail.
The text was updated successfully, but these errors were encountered: