Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polymer/build/all_phases_test is timing out on jsshell #18910

Closed
whesse opened this issue May 20, 2014 · 11 comments
Closed

polymer/build/all_phases_test is timing out on jsshell #18910

whesse opened this issue May 20, 2014 · 11 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request

Comments

@whesse
Copy link
Member

whesse commented May 20, 2014

The dart2js jsshell buildbot slave is timing out on the test pkg/polymer/test/build/all_phases_test.dart sometimes.
In the cases where it does not time out, it takes 43 or 50 seconds, and it does time out after 60 seconds. So the test just seems to take a long time on jsshell. It should be made faster, or if necessary marked slow in the status file.
@sigmundch
Copy link
Member

Is this slowliness always or in a specific mode (checked or debug)?

We should probably mark it as slow for now, or skip it in jsshell. This test runs the polymer transformers, which are intended to only run in the vm anyways.

Internally, the tests are running the analyzer and resolving types. The analyzer today will resolve all of dart:html among other things. We've talked about having a mock version of dart:html for this, or improving the analyzer to be more lazy and only resolve/analyze types as they are needed. But I don't see that happening for some time.

@jmesserly
Copy link

agree on skipping.

@jmesserly
Copy link

Removed Area-Polymer label.
Added area-pkg, Pkg-Polymer labels.

@jmesserly
Copy link

Removed Library-Polymer label.

@sigmundch
Copy link
Member

Added this to the Later milestone.

@sigmundch
Copy link
Member

Removed Priority-Medium label.
Added Priority-Low label.

@sigmundch
Copy link
Member

Added Polymer-P-2 label.

@sigmundch
Copy link
Member

Removed this from the Later milestone.

@sigmundch
Copy link
Member

Removed Polymer-P-2 label.
Added Polymer-Milestone-Later label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Later label.
Added PolymerMilestone-Later label.

@whesse whesse added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request labels Jul 9, 2014
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#187.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @jmesserly @sigmundch @whesse @DartBot