Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartanalyzer fails in batch mode in checkouts with a space in the path #18908

Closed
whesse opened this issue May 20, 2014 · 7 comments
Closed

dartanalyzer fails in batch mode in checkouts with a space in the path #18908

whesse opened this issue May 20, 2014 · 7 comments
Assignees
Labels
analyzer-command Issues with the command-line dartanalyzer tool area-analyzer P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@whesse
Copy link
Member

whesse commented May 20, 2014

On Windows and linux, if there is a space in the path of a dart checkout, running tools/test.py -cdartanalyzer -rnone will show most tests failing, with the error

File not found: [absolute path of checkout, truncated at first space]

Other failures found (from the test infrastructure) when running in --nobatch mode are being fixed, but this issue is due to the batch mode of dartanalyzer (--client flag) reading the input file name from stdin, and parsing it by splitting it on spaces. Even enclosing the file name in quotes, when the test runner puts it on stdin of the dartanalyzer (java) running in batch mode, does not succeed - it is still truncated at the space. The analyzer needs to do a cleverer job of parsing the batch input, and then the test runner needs to be modified too.

This probably needs to be fixed in the Dart version of the analyzer too. I believe floitch is working on a similar issue for dart2js.

@bwilkerson
Copy link
Member

Added this to the 1.5 milestone.
Added Area-Analyzer label.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@bwilkerson
Copy link
Member

Is this still an issue?
If so, has it been fixed for dart2js?
If so, do you know what the change was (so that we can be consistent)?


Set owner to @whesse.

@bwilkerson
Copy link
Member

Set owner to @pq.

@whesse whesse added Type-Defect P3 A lower priority bug or feature request area-analyzer analyzer-command Issues with the command-line dartanalyzer tool labels Apr 22, 2015
@bwilkerson bwilkerson removed the Triaged label Nov 4, 2015
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed Type-Defect labels Mar 1, 2016
@pq
Copy link
Member

pq commented Jun 21, 2018

I believe this is no longer an issue?

@pq pq closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-command Issues with the command-line dartanalyzer tool area-analyzer P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

5 participants