Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[template_binding] interop instead of porting #18893

Closed
jmesserly opened this issue May 19, 2014 · 9 comments
Closed

[template_binding] interop instead of porting #18893

jmesserly opened this issue May 19, 2014 · 9 comments
Labels
area-pkg type-enhancement A request for a change that isn't a bug

Comments

@jmesserly
Copy link

https://github.com/Polymer/TemplateBinding/blob/master/src/TemplateBinding.js
https://github.com/Polymer/NodeBind/blob/master/src/NodeBind.js

... are by-hand ports, because we didn't have JS interop when they were written.

It would be better to interop. They are already included in the pub.dartlang.org/packages/web_components package platform.js. Most of TemplateBinding code is dealing with the semantics of <template> and its repeat/if/bind attributes. The code isn't really Dart specific. We'd have to measure performance tradeoffs, but it might not make much difference in the context of stamping a template.

One other challenge is TemplateBinding depends on observe-js, which itself depends on reflective operations on JS objects. So it won't work without addressing that layer. We might be able to get pretty far just by patching "Path" in observe-js, but needs more investigation to be sure.

@jmesserly
Copy link
Author

hmmmm. it seems if you have a bindingDelegate, paths aren't used. So maybe ArrayObserver is the only one to deal with

@sigmundch
Copy link
Member

Removed this from the Later milestone.
Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@sigmundch
Copy link
Member

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Next label.

@jmesserly
Copy link
Author

Issue #19109 has been merged into this issue.


cc @sigmundch.
cc @jakemac53.

@jmesserly
Copy link
Author

Issue #21354 has been merged into this issue.

@jmesserly
Copy link
Author

dart-archive/template-binding#3


Added MovedToGithub label.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants