New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[template_binding] interop instead of porting #18893
Comments
hmmmm. it seems if you have a bindingDelegate, paths aren't used. So maybe ArrayObserver is the only one to deal with |
Removed this from the Later milestone. |
Removed this from the 1.6 milestone. |
Removed Polymer-P-1 label. |
Added PolymerMilestone-Next label. |
Removed Polymer-Milestone-Next label. |
Issue #19109 has been merged into this issue. cc @sigmundch. |
Issue #21354 has been merged into this issue. |
dart-archive/template-binding#3 Added MovedToGithub label. |
https://github.com/Polymer/TemplateBinding/blob/master/src/TemplateBinding.js
https://github.com/Polymer/NodeBind/blob/master/src/NodeBind.js
... are by-hand ports, because we didn't have JS interop when they were written.
It would be better to interop. They are already included in the pub.dartlang.org/packages/web_components package platform.js. Most of TemplateBinding code is dealing with the semantics of <template> and its repeat/if/bind attributes. The code isn't really Dart specific. We'd have to measure performance tradeoffs, but it might not make much difference in the context of stamping a template.
One other challenge is TemplateBinding depends on observe-js, which itself depends on reflective operations on JS objects. So it won't work without addressing that layer. We might be able to get pretty far just by patching "Path" in observe-js, but needs more investigation to be sure.
The text was updated successfully, but these errors were encountered: