Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hint about statements with no effect #18849

Closed
stevemessick opened this issue May 15, 2014 · 5 comments
Closed

Hint about statements with no effect #18849

stevemessick opened this issue May 15, 2014 · 5 comments
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@stevemessick
Copy link
Contributor

ldap: codefu

Ideally, I'd like a warning about code where I might have forgotten to add "return" :)
Example:

if (test cases) {
  null;
}
return something;

same with:
false;
true;

////////////////////////////////////////////////////////////////////////////////////
Editor: 1.4.0.dev_06_04 (2014-05-12)
OS: Linux - amd64 (3.2.5-gg1336)
JVM: 1.7.0-google-v6

projects: 6

open dart files: 34

auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 1778 / 778 / 239 MB
thread count: 31
index: 620939 relationships in 110214 keys in 762 sources

SDK installed: true
Dartium installed: true
@bwilkerson
Copy link
Member

Added Analyzer-Hint label.

@bwilkerson
Copy link
Member

Removed this from the 1.5 milestone.
Added this to the Later milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@stevemessick stevemessick added Type-Enhancement area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-warning Issues with the analyzer's Warning codes labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
This was referenced Apr 20, 2016
Closed
Open
@bwilkerson bwilkerson added analyzer-linter Issues with the analyzer's support for the linter package and removed analyzer-warning Issues with the analyzer's Warning codes labels Aug 15, 2016
@bwilkerson bwilkerson removed their assignment Aug 15, 2016
@bwilkerson
Copy link
Member

I believe that the unnecessary_statements lint should satisfy this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @kasperl @bwilkerson @stevemessick