Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter option to remove excess parens #18656

Closed
stevemessick opened this issue May 6, 2014 · 6 comments
Closed

Formatter option to remove excess parens #18656

stevemessick opened this issue May 6, 2014 · 6 comments
Assignees
@pq
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug

Comments

@stevemessick
Copy link
Contributor

I'd like to propose an enhancement to the code formatter: eliminate unnecessary parentheses.
That is, for example:
(i == 0) && (j == 1)
should be rewritten to:
i == 0 && j == 1

That way we can forget about all the operator precedence rules, and on the other hand, we get shorter source files :)

Please CC me if you create an enhancement/bug for this: federico.omoto@gmail.com
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.3.6.release (2014-04-29)
OS: Linux - amd64 (3.14.2-200.fc20.x86_64)
JVM: 1.7.0_55

projects: 3

open dart files: 6

auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 1778 / 916 / 783 MB
thread count: 24
index: 374797 relationships in 42550 keys in 480 sources

SDK installed: true
Dartium installed: true
@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@munificent
Copy link
Member

Added NotPlanned label.

@pq
Copy link
Member

pq commented Feb 13, 2015

Aside: does this come up often in reviews? Should we create a lint?

@stevemessick stevemessick added Type-Enhancement closed-not-planned Closed as we don't intend to take action on the reported issue labels Feb 13, 2015
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/dart_style#347.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @munificent @pq @kasperl @stevemessick @DartBot