Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close() method in DialogElement class under dart:html should have its parameter optional #18579

Closed
DartBot opened this issue May 1, 2014 · 12 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented May 1, 2014

This issue was originally filed by dvor...@gmail.com


What steps will reproduce the problem?

  1. create HTML element as DialogElement
  2. call element.close()

What is the expected output? What do you see instead?
According to the W3C DOM and W3C HTML5 specs the parameter of the close() method should be optional only. But if I run it through both dartanalyzer and pub build, it throws an error.

What version of the product are you using? On what operating system?
Dart SDK 1.3.6 on Windows 7

@DartBot
Copy link
Author

DartBot commented May 1, 2014

This comment was originally written by dvorap...@gmail.com


*if I run it without any parameter

@DartBot
Copy link
Author

DartBot commented May 1, 2014

This comment was originally written by dvorapa...@gmail.com


And the second bug with close():

What steps will reproduce the problem?

  1. create HTML element in HTML file
  2. query it into your dart script as DialogElement
  3. call element.show()
  4. call element.close('some returned value')
  5. run pub build and open the HTML file

What is the expected output? What do you see instead?
The dialog element should be shown if I call show() method and closed if I call close() method. It shows properly, but if I click on the button, which's click event listener calls close() method, it doesn't close.

What version of the product are you using? On what operating system?
Dart SDK 1.3.6 on Windows 7

Please provide any additional information below.
Interesting thing is, that the method hide(), which is not specified anywhere in the api.dartlang.org closes the dialog element perfectly!

@sgjesse
Copy link
Contributor

sgjesse commented May 5, 2014

Added Area-Library, Library-Html, Triaged labels.

@efortuna
Copy link
Contributor

I have a change out for changing the optionality of the parameter of close().

However, as a reminder DialogElement is unstable, so features are likely to break.


Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Low label.

@efortuna
Copy link
Contributor

efortuna commented Jun 9, 2014

I had a CL for this, but I talked with Leaf, and we're going to do a more comprehensive change on default values of optional parameters soon. Leaf is on it.


Set owner to @leafpetersen.
Removed this from the Later milestone.
Removed Priority-Low label.
Added Priority-Medium label.

@DartBot
Copy link
Author

DartBot commented Sep 30, 2014

This comment was originally written by aleskv...@mailinator.com


Any progress on this?

@leafpetersen
Copy link
Member

Thanks for the ping. We've landed support for default values in our bindings layer. I've not yet pushed on surfacing this in dart:html, since there are quite a few other changes going on under the hood in that code right now. Assuming that there is no push back, I'll probably try to surface this soon. Setting milestone to 1.8 as a reminder to myself.


Added this to the 1.8 milestone.

@kasperl
Copy link

kasperl commented Oct 15, 2014

Since this is assigned to the 1.8 milestone, I'm bumping the priority to high. Feel free to lower the priority and remove the 1.8 milestone marker.


Removed Priority-Medium label.
Added Priority-High label.

@leafpetersen
Copy link
Member

Removed this from the 1.8 milestone.
Added this to the 1.9 milestone.

@kasperl
Copy link

kasperl commented Nov 28, 2014

Added Accepted label.

@leafpetersen
Copy link
Member

cc @alan-knight.
Removed the owner.
Removed this from the 1.9 milestone.
Added this to the 1.10 milestone.
Removed Priority-High label.
Added Priority-Low label.

@dgrove
Copy link
Contributor

dgrove commented Apr 17, 2015

Removed this from the 1.10 milestone.

@DartBot DartBot added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html P3 A lower priority bug or feature request labels Apr 17, 2015
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

8 participants