New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
close() method in DialogElement class under dart:html should have its parameter optional #18579
Comments
This comment was originally written by dvorap...@gmail.com *if I run it without any parameter |
This comment was originally written by dvorapa...@gmail.com And the second bug with close(): What steps will reproduce the problem?
What is the expected output? What do you see instead? What version of the product are you using? On what operating system? Please provide any additional information below. |
Added Area-Library, Library-Html, Triaged labels. |
I have a change out for changing the optionality of the parameter of close(). However, as a reminder DialogElement is unstable, so features are likely to break. Added this to the Later milestone. |
I had a CL for this, but I talked with Leaf, and we're going to do a more comprehensive change on default values of optional parameters soon. Leaf is on it. Set owner to @leafpetersen. |
This comment was originally written by aleskv...@mailinator.com Any progress on this? |
Thanks for the ping. We've landed support for default values in our bindings layer. I've not yet pushed on surfacing this in dart:html, since there are quite a few other changes going on under the hood in that code right now. Assuming that there is no push back, I'll probably try to surface this soon. Setting milestone to 1.8 as a reminder to myself. Added this to the 1.8 milestone. |
Since this is assigned to the 1.8 milestone, I'm bumping the priority to high. Feel free to lower the priority and remove the 1.8 milestone marker. Removed Priority-Medium label. |
Added Accepted label. |
cc @alan-knight. |
Removed this from the 1.10 milestone. |
This issue was originally filed by dvor...@gmail.com
What steps will reproduce the problem?
What is the expected output? What do you see instead?
According to the W3C DOM and W3C HTML5 specs the parameter of the close() method should be optional only. But if I run it through both dartanalyzer and pub build, it throws an error.
What version of the product are you using? On what operating system?
Dart SDK 1.3.6 on Windows 7
The text was updated successfully, but these errors were encountered: