Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support union arguments in new IDL #18564

Closed
vsmenon opened this issue Apr 30, 2014 · 9 comments
Closed

Support union arguments in new IDL #18564

vsmenon opened this issue Apr 30, 2014 · 9 comments
Assignees
@terrylucas
Labels
P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@vsmenon
Copy link
Member

vsmenon commented Apr 30, 2014

We're seeing syntax like the following in Blink IDL:

  [ImplementedAs=namedGetter] getter (NodeList or Element) namedItem(DOMString name);

This requires C++ code that handles both types to be generated.

I'm modifying the template to throw for now when this case is encountered at runtime.
@vsmenon
Copy link
Member Author

vsmenon commented Apr 30, 2014

Marked this as blocking #18364.

@kasperl
Copy link

kasperl commented May 8, 2014

Removed this from the 1.4 milestone.
Added this to the 1.5 milestone.

@vsmenon
Copy link
Member Author

vsmenon commented May 26, 2014

Terry, is there anything further to do here?

@vsmenon
Copy link
Member Author

vsmenon commented May 26, 2014

Unmarked this as blocking #18364.

@terrylucas
Copy link
Contributor

named item getters are not fully support in the dart:blink code however, dart:html never uses blink for these so it's not critical for 1.5. We should fix for completeness after the 36 roll.

Removed Priority-Critical label.
Added Priority-Low label.

@vsmenon
Copy link
Member Author

vsmenon commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@vsmenon vsmenon added Type-Defect P3 A lower priority bug or feature request labels Aug 4, 2014
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Mar 1, 2016
@terrylucas
Copy link
Contributor

Closed unions are generated as dynamic until Dart supports either union or function overloading.

@eernstg eernstg mentioned this issue Nov 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrylucas terrylucas

Labels
P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @terrylucas @vsmenon @kasperl