Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GVN on safe dynamic invocations #18519

Closed
ghost opened this issue Apr 29, 2014 · 2 comments
Closed

Enable GVN on safe dynamic invocations #18519

ghost opened this issue Apr 29, 2014 · 2 comments
Labels
P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js

Comments

@ghost
Copy link

ghost commented Apr 29, 2014

Currently, GVN is disabled on dynamic invocations even if the invoked target does not have side effects, as it might produce different values for each invocation (e.g. by allocating a new object).

gvn_dynamic_field_get_test is a dart2js test with an example.
@ghost
Copy link
Author

ghost commented Apr 29, 2014

cc @karlklose.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
@rakudrama
Copy link
Member

I'm going to close this.
We could do better GVN on idempotent operations, but very few would be from dynamic calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @rakudrama