Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respecting Polymer ImportInliner path reaching packages warning breaks in Dartium #18473

Closed
DartBot opened this issue Apr 27, 2014 · 19 comments
Closed
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-obsolete Closed as the reported issue is no longer relevant

Comments

@DartBot
Copy link

DartBot commented Apr 27, 2014

This issue was originally filed by joh...@johnmccutchan.com


If I follow the following advice:

[Error from polymer (ImportInliner) on observatory|web/index.html]:
lib/src/elements/vm_ref.html:5:11: Invalid url to reach to another package: packages/observatory/src/elements/css/shared.css. Path reaching to other packages must first reach up all the way to the packages folder. For example, try changing the url above to: ../../../../packages/observatory/src/elements/css/shared.css

aka

replace packages/observatory/src/elements/css/shared.css with ../../../../packages/observatory/src/elements/css/shared.css

The application works when compiled to dart2js but fails in Dartium.

Leaving it as packages/observatory/src/elements/css/shared.css causes the application to work when compiled to dart2js and in Dartium.

@DartBot
Copy link
Author

DartBot commented Apr 27, 2014

This comment was originally written by joh...@johnmccutchan.com


Correct:

With the ../../../ the application works under dart2js but not Dartium
Without the ../../../ the application works under Dartium but not dart2js.

@DartBot
Copy link
Author

DartBot commented Apr 27, 2014

This comment was originally written by joh...@johnmccutchan.com


s/Correct:/Correction:

@lrhn
Copy link
Member

lrhn commented Apr 28, 2014

Added Area-Polymer, Triaged labels.

@sigmundch
Copy link
Member

John - can you remind us is this with 0.9.5 or 0.10.0-dev.9?

@DartBot
Copy link
Author

DartBot commented Apr 28, 2014

This comment was originally written by joh...@johnmccutchan.com


I'm using 1.4.0.dev_04_00

@sigmundch
Copy link
Member

Sorry, I was wondering about the version of the polymer package, since both 0.9.5+1 and 0.10.0-dev.9 are supported in the 1.4 SDK.

I addressed some of these issues in 0.10.0-dev.9, but I'm not sure if they are enough to fix your issue. Can you give me some pointers on how to try out building observatory?

Thanks!

@DartBot
Copy link
Author

DartBot commented Apr 28, 2014

This comment was originally written by joh...@johnmccutchan.com


Hi,

We use the dev channel release of the SDK (latest 1.4.0 dev release).

name: observatory
version: 0.1.9
dependencies:
  polymer: any
  logging: any
transformers:

  • polymer:
        entry_points:
          - web/index.html
          - web/index_devtools.html

@sigmundch
Copy link
Member

We talked about this offline, but just to bring the bug up to date. This resolves to polymer 0.9.5+2, which is the latest released version of polymer, the "-dev" versions are considered pre-releases and pub gives priority to released versions if they are available in your version constraint (in your case "any").

We should give 0.10.* a try with your code to make sure that this issue was resolved. If so, we should consider doing the upgrade. There were some breaking changes that we announced in the mailing list, we also have pending to update the documentation to include more details.

An unrelated comment: it might be worth changing your polymer constraint to something else, for example:

  polymer: ">=0.9.0 <0.10.0"

instead of "any". When we finally release 0.10, using 'any' will cause that once you call 'pub upgrade' the app will likely stop working. If you want to be more in control of when you move from one version to a newer version that has breaking changes, it's a good idea to include an upperbound on the constraint.

@jmesserly
Copy link

Removed Area-Polymer label.
Added Pkg-Polymer, Area-Pkg labels.

@sigmundch
Copy link
Member

John McCutchan - now that you are on polymer 0.11.0, is this still an issue?


Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium, NeedsInfo labels.

@sigmundch
Copy link
Member

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member

Removed Pkg-Polymer label.
Added Pkg-PolymerBuild label.

@sigmundch
Copy link
Member

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

Pinging @­johnmccutchan - is this still an issue?

@DartBot
Copy link
Author

DartBot commented Aug 30, 2014

This comment was originally written by @zoechi


As far as I know this is solved since a while.

It is still bothersome that DartEditor (and also WebStorm) can't work with the path Polymer expects. Polymer needs one ../ more than the tools expect therefore navigating from the import link element to the imported html file doesn't work.

After removing one ../ navigating to the imported file works but then pub serve complains.

@sigmundch
Copy link
Member

Good point @­gzoechi, that makes sense - we should create some bugs to track adding support for 'packages/' imports in HTML imports on tools like the editor and webstorm.

I created this bug about adding more documentation for these imports, so we can refer to is from other bugs as well: dart-archive/www.dartlang.org#916


Added AssumedStale label.

@DartBot DartBot added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-obsolete Closed as the reported issue is no longer relevant labels Sep 2, 2014
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#389.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Development

No branches or pull requests

4 participants