Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter should prefer to break within named args instead of ArgType-ArgValue pairs #18467

Closed
DartBot opened this issue Apr 27, 2014 · 8 comments
Assignees
Labels
closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Apr 27, 2014

This issue was originally filed by andrew.m...@gmail.com


Current:

class GlobSegment2 {
  Pattern _expression;
  final bool crossesDirectory;
  final String pattern;
  final bool strict;
  final bool trailingSlash;

  GlobSegment2(this.pattern, Pattern
      expression, {this.crossesDirectory, this.strict, this.trailingSlash}) {
  }
}

Should be:

class GlobSegment2 {
  Pattern _expression;
  final bool crossesDirectory;
  final String pattern;
  final bool strict;
  final bool trailingSlash;

  GlobSegment2(this.pattern, Pattern expression, {this.crossesDirectory,
    this.strict, this.trailingSlash}) {
  }
}

@kevmoo
Copy link
Member

kevmoo commented Apr 27, 2014

Marked this as blocking #16327.

@kevmoo
Copy link
Member

kevmoo commented Apr 27, 2014

Added Area-Formatter, Triaged labels.
Changed the title to: "Formatter should prefer to break within named args instead of ArgType-ArgValue pairs ".

@clayberg
Copy link

Set owner to @pq.
Added this to the 1.5 milestone.
Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-Medium labels.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@munificent
Copy link
Member

Added AssumedStale label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/dart_style#346.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

6 participants