Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnBeforeUnload event doesnt work with Polymer + Dart2Js #18428

Closed
DartBot opened this issue Apr 24, 2014 · 12 comments
Closed

OnBeforeUnload event doesnt work with Polymer + Dart2Js #18428

DartBot opened this issue Apr 24, 2014 · 12 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request

Comments

@DartBot
Copy link

DartBot commented Apr 24, 2014

This issue was originally filed by bendera...@google.com

What steps will reproduce the problem?

  1. Create new sample web app using polymer from dart editor
  2. add:

 window.onBeforeUnload.listen((BeforeUnloadEvent e) {
     e.returnValue = "no dont leave";
   });

to enteredView of main component

  1. run app as ajavascript
  2. attempt to navigate somewhere else

What is the expected output?

I would expect to see a browser dialog window indicating warning me that Im about to leave and it should include the message 'no dont leave'.

What do you see instead?
No dialog, navigation proceeds unimpeded.

What version of the product are you using? On what operating system?
This was tested on ubuntu, with DartEditor 35068, I tested in both Chrome 34 and contemporary FF and it doesnt work. However, it does work correctly in dartium.
@lrhn
Copy link
Member

lrhn commented Apr 25, 2014

Added Library-Html, Triaged labels.

@lrhn
Copy link
Member

lrhn commented Apr 25, 2014

Added Area-Library label.

@blois
Copy link
Contributor

blois commented Apr 25, 2014

Appears to work properly in dart2js without Polymer.

Removed Library-Html, Area-Library labels.
Added Library-Polymer, Area-Pkg labels.

@sigmundch
Copy link
Member

Removed Area-Pkg label.
Added Area-Polymer label.

@jmesserly
Copy link

Removed Area-Polymer label.
Added area-pkg, Pkg-Polymer labels.

@jmesserly
Copy link

Removed Library-Polymer label.

@sigmundch
Copy link
Member

Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Low label.

@sigmundch
Copy link
Member

Added Polymer-P-2 label.

@sigmundch
Copy link
Member

Removed this from the Later milestone.

@sigmundch
Copy link
Member

Removed Polymer-P-2 label.
Added Polymer-Milestone-Later label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Later label.
Added PolymerMilestone-Later label.

@DartBot DartBot added Type-Defect P3 A lower priority bug or feature request area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jul 9, 2014
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#170.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @jmesserly @sigmundch @blois @lrhn @DartBot