Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix example in polymer_expressions package #18313

Closed
sigmundch opened this issue Apr 18, 2014 · 10 comments
Closed

fix example in polymer_expressions package #18313

sigmundch opened this issue Apr 18, 2014 · 10 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request

Comments

@sigmundch
Copy link
Member

The polymer_expressions exaple fails if you run it in chrome because it doesn't retain symbols used via mirrors. Here is the original report from Ravi:
https://groups.google.com/a/dartlang.org/d/msgid/web/eea7bc07-e758-449b-95e2-7abf04b4ca89%40dartlang.org?utm_medium=email&utm_source=footer

We should fix this with a @­MirrorsUsed annotation or a transformer that generates code for it.
@jmesserly
Copy link

Removed Area-Polymer label.
Added Area-Pkg, Pkg-PolymerExpressions labels.

@jmesserly
Copy link

Removed Library-PolymerExpressions label.

@sigmundch
Copy link
Member Author

https://codereview.chromium.org/370463005/

Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-Low, Started labels.

@sigmundch
Copy link
Member Author

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member Author

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member Author

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member Author

Removed Polymer-Milestone-Next label.

@DartBot
Copy link

DartBot commented Oct 20, 2014

This comment was originally written by tejai...@gmail.com

I would be great if somebody could update about the status of this issue.

Thanks

@sigmundch
Copy link
Member Author

Sorry I forgot to mark the bug as fixed. Thanks for the ping.

I submitted the fix above in r38566 (about 2 months ago.)

Added Fixed label.

@sigmundch sigmundch added Type-Defect P3 A lower priority bug or feature request area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Oct 20, 2014
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#495.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmesserly @sigmundch @DartBot