Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor error recovery when () missing from function declaration #18244

Closed
stereotype441 opened this issue Apr 15, 2014 · 6 comments
Closed

Poor error recovery when () missing from function declaration #18244

stereotype441 opened this issue Apr 15, 2014 · 6 comments
Assignees
Labels
analyzer-recovery area-analyzer type-enhancement A request for a change that isn't a bug

Comments

@stereotype441
Copy link
Member

The following source (adapted from tests/language/function_syntax_test.dart) generates 62 errors and 4 warnings in the editor:

class FunctionSyntaxTest {
  static void testInitializers // Note: missing '()'
  {
    Expect.equals(42, (new C.cb0().fn)());
    Expect.equals(43, (new C.ca0().fn)());
  }
}

It looks like the parser is getting completely lost and trying to parse everything between the inner set of braces as part of a class declaration. We really should be able to do a better job of error recovery than this.

@bwilkerson
Copy link
Member

Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@bwilkerson
Copy link
Member

Removed Type-Defect label.
Added Type-Enhancement label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@bwilkerson
Copy link
Member

cc @stereotype441.
Set owner to @bwilkerson.
Added Started label.

@bwilkerson
Copy link
Member

https://codereview.chromium.org/772423004/ (bleeding edge revision 42097)


Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-recovery area-analyzer type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants