Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings now in factory_redirection_test/* #18230

Closed
jwren opened this issue Apr 14, 2014 · 1 comment
Closed

Warnings now in factory_redirection_test/* #18230

jwren opened this issue Apr 14, 2014 · 1 comment
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jwren
Copy link
Member

jwren commented Apr 14, 2014

Fix in type algebra in analyzer (issue #14221) shows a static warning. Analyzer change has not landed yet.

Sample of failure: WARNING|STATIC_TYPE_WARNING|RETURN_OF_INVALID_TYPE|/Users/jwren/src/dart/dart/xcodebuild/ReleaseIA32/generated_tests/language/factory1_test_none.dart|10|12|15|The return type 'A<String>' is not a 'A<T>', as defined by the method 'factory'

factory_redirection_test/02: StaticWarning
factory_redirection_test/08: StaticWarning
factory_redirection_test/09: StaticWarning
factory_redirection_test/10: StaticWarning
factory_redirection_test/11: StaticWarning
factory_redirection_test/12: StaticWarning
factory_redirection_test/13: StaticWarning
factory_redirection_test/14: StaticWarning
factory_redirection_test/none: StaticWarning
@whesse
Copy link
Member

whesse commented Apr 15, 2014

It looks to me, looking at the specification, that this is correctly a static warning,
since A<String> is not assignable to A<T>. So the errors in the test should be changed to:

/// 00: static type warning, dynamic type error
/// 01: static type warning, dynamic type error

Check the spec for "return" statement, and parameterized types. I would pass the resulting CL by a language spec expert.

The Area-Test label is deprecated, since tests are assumed to be the responsibility of the area tested. Problems with the test framework should go to Area-Infrastructure.

cc @gbracha.
Set owner to @jwren.
Removed Area-Test label.
Added Area-Language label.

@jwren jwren added Type-Defect area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). labels Apr 15, 2014
@jwren jwren self-assigned this Apr 15, 2014
@jwren jwren removed their assignment Oct 6, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Mar 1, 2016
@munificent munificent added the closed-obsolete Closed as the reported issue is no longer relevant label Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @munificent @jwren @whesse