New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocGen reports the wrong return type of Converter.convert #18199
Comments
This comment was originally written by bslesinsk...@gmail.com The types for the encode() and decode() methods in the Codec class also disagree with the article. |
Sadly, our API doc generator has issues with generics. It ends up reporting the wrong type often. See https://code.google.com/p/dart/issues/detail?id=17450 The return type is indeed T - https://github.com/dart-lang/bleeding_edge/blob/master/dart/sdk/lib/convert/converter.dart#L19 |
Added Pkg-DocGen, Area-Pkg, Triaged labels. |
De-duping this issue. Issue #17450 is fixed for Iterable, which seemed related, but this is clearly still broken for Converter https://api.dartlang.org/apidocs/channels/be/dartdoc-viewer/dart-convert.Converter Removed Priority-Unassigned label. |
Added this to the 1.6 milestone. |
Marked as High, assigning owner. If I get this wrong, please help me by: * assigning a new owner
Set owner to @alan-knight. |
Removed the owner. |
Moved to dart-lang/dartdoc#81 Added MovedToGithub label. |
This issue was originally filed by bslesi...@gmail.com
According to the API doc [1], convert() has type:
String convert(S input);
However, according to the Converters and Codecs article [2], it should be:
T convert(S input);
I believe the article is correct and the code is wrong. If not, maybe an explanation should be added.
[1] https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart-convert.Converter
[2] https://www.dartlang.org/articles/converters-and-codecs/#converter
The text was updated successfully, but these errors were encountered: