Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

launch_browser.dart does not support --dartium flag #18155

Closed
justinfagnani opened this issue Apr 10, 2014 · 2 comments
Closed

launch_browser.dart does not support --dartium flag #18155

justinfagnani opened this issue Apr 10, 2014 · 2 comments
Assignees
@whesse
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@justinfagnani
Copy link
Contributor

If you run ./tools/test.py with the --dartium flag, like so:

./tools/test.py --mode=release --compiler=none --runtime=dartium --tasks=1 --dartium=../../dartium-git/src/out/Debug/Chromium.app/Contents/MacOS/Chromium html/js_test

and it fails, it will print something like this:

To retest, run: /Users/justinfagnani/Documents/Projects/dart2-repo/dart/tools/testing/bin/macos/dart /Users/justinfagnani/Documents/Projects/dart2-repo/dart/tools/testing/dart/http_server.dart -p 51496 -c 51497 --build-directory=/Users/justinfagnani/Documents/Projects/dart2-repo/dart/xcodebuild/ReleaseIA32 --runtime=dartium

Command[dartium]: /Users/justinfagnani/Documents/Projects/dart2-repo/dart/tools/testing/bin/macos/dart tools/testing/dart/launch_browser.dart dartium http://127.0.0.1:51496/root_build/generated_tests/none-dartium/tests_html_js_test/test.html?crossOriginPort=51497

Notice that the Command[dartium] does not include the path to the Dartium binary originally used, nor does launch_browser.dart seem to support a --dartium flag
@ricowind
Copy link
Contributor

Set owner to @whesse.
Removed Priority-Unassigned label.
Added Priority-Medium, Accepted labels.

@justinfagnani justinfagnani added Type-Defect area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Apr 11, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@athomas
Copy link
Member

athomas commented Aug 15, 2017

Dartium will no longer be supported in 2.0.

@athomas athomas closed this as completed Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @justinfagnani @whesse @ricowind @athomas