Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language/disassemble_test fails on drt due to test infrastructure #18122

Closed
whesse opened this issue Apr 9, 2014 · 3 comments
Closed

language/disassemble_test fails on drt due to test infrastructure #18122

whesse opened this issue Apr 9, 2014 · 3 comments
Assignees
@whesse
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@whesse
Copy link
Member

whesse commented Apr 9, 2014

test.dart searches the output of context_shell for "PASS" or "FAIL". language/disassemble_test generates more than 100,000 characters (the disassembly of all generated code), so it is truncated in the middle. This drops the part of the output that says PASS, so the test fails.

We should change this way of reporting success, or we should make the truncation code look for PASS or FAIL in the output it is dropping, and put it back in the output.
@whesse whesse added Type-Defect P3 A lower priority bug or feature request area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Apr 9, 2014
@whesse whesse self-assigned this Apr 9, 2014
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Mar 1, 2016
@sjindel-google
Copy link
Contributor

This seems to be causing frequent flakiness on vm-kernel-linux-x64-try, e.g. https://ci.chromium.org/p/dart/builders/luci.dart.try/vm-kernel-linux-release-x64-try/287, which is becoming a serious issue for passing the CQ.

@sjindel-google sjindel-google added P2 A bug or feature request we're likely to work on and removed P3 A lower priority bug or feature request labels May 8, 2018
@whesse
Copy link
Member Author

whesse commented May 8, 2018

This is an issue about context_shell, which we have stopped using. Is the problem that the same test is flaky on the vm? language/disassemble_test?

I would file a new issue, and close this one as obsolete.

@sjindel-google
Copy link
Contributor

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @whesse @sjindel-google