Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge errors/warnings from multiple contexts #18120

Open
danrubel opened this issue Apr 9, 2014 · 7 comments
Open

Merge errors/warnings from multiple contexts #18120

danrubel opened this issue Apr 9, 2014 · 7 comments
Labels
area-analyzer P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@danrubel
Copy link

danrubel commented Apr 9, 2014

If a file is directly or indirectly contained in multiple contexts, then all of the errors/warnings/hints for those context should be displayed for the user. Currently only the results for context whose analysis runs "last" (non-deterministic) are shown.

@danrubel
Copy link
Author

danrubel commented Apr 9, 2014

Per discussion, recommended that we not modify AnalysisMarkerManager, but rather create a new object that combines results from multiple contexts ensuring that the AnalysisMarkerManager always receive a complete list of all known errors/warnings/hints for any given resource.


cc @bwilkerson.

@kasperl
Copy link

kasperl commented May 8, 2014

Removed this from the 1.4 milestone.
Added this to the 1.5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@sethladd
Copy link
Contributor

This sounds like an analyzer issue? Or is this purely an Editor UI issue?

Tentatively reclassifying...


Removed Priority-Medium, Area-Editor labels.
Added Priority-Low, Area-Analyzer labels.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@danrubel danrubel added Type-Enhancement P3 A lower priority bug or feature request area-analyzer labels Aug 4, 2014
@danrubel danrubel self-assigned this Aug 4, 2014
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
@danrubel danrubel removed their assignment Jan 13, 2020
@srawlins
Copy link
Member

@scheglov can files be considered to be "in" multiple contexts? Is this perhaps obsolete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants