Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer hint for empty if statements #18089

Closed
DartBot opened this issue Apr 8, 2014 · 5 comments
Closed

Analyzer hint for empty if statements #18089

DartBot opened this issue Apr 8, 2014 · 5 comments
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Apr 8, 2014

This issue was originally filed by greg.lowe...@gmail.com


Would be nice if the editor/analyzer would show a hint warning of the extra semicolon trailing the if statement in the following example:

    if (foo == bar);
      foobar();

@bwilkerson
Copy link
Member

Added this to the Later milestone.
Added Type-Enhancement, Priority-Medium, Area-Analyzer, Analyzer-Hint, Triaged labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@DartBot DartBot added Type-Enhancement area-analyzer analyzer-warning Issues with the analyzer's Warning codes labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
@srawlins
Copy link
Member

Since this is valid syntax (the semicolon is expressly allowed in the language), I think this would be a linter lint.

@bwilkerson bwilkerson added analyzer-linter Issues with the analyzer's support for the linter package and removed analyzer-warning Issues with the analyzer's Warning codes labels Apr 20, 2016
@bwilkerson
Copy link
Member

This has been implemented by the empty_statements lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants