Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatter should start a new line for each annotation #17938

Closed
DartBot opened this issue Apr 1, 2014 · 9 comments
Closed

formatter should start a new line for each annotation #17938

DartBot opened this issue Apr 1, 2014 · 9 comments
Assignees
Labels
closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Apr 1, 2014

This issue was originally filed by @zoechi


What steps will reproduce the problem?
1.
formatter generates:

@NgComponent(selector: 'alert', publishAs: 't', applyAuthorStyles: true,
    templateUrl: 'packages/angular_ui/alert/alert.html')@NgComponent(selector:
    '[alert]', publishAs: 't', applyAuthorStyles: true, templateUrl:
    'packages/angular_ui/alert/alert.html')
class Alert {
  @­NgOneWay('type')
  String type;
2.
3.

What is the expected output? What do you see instead?
@NgComponent(selector: 'alert', publishAs: 't', applyAuthorStyles: true,
    templateUrl: 'packages/angular_ui/alert/alert.html')
@NgComponent(selector:
    '[alert]', publishAs: 't', applyAuthorStyles: true, templateUrl:
    'packages/angular_ui/alert/alert.html')
class Alert {

or even better

@NgComponent(
    selector: 'alert',
    publishAs: 't',
    applyAuthorStyles: true,
    templateUrl: 'packages/angular_ui/alert/alert.html'
)
@NgComponent(
    selector: '[alert]',
    publishAs: 't',
    applyAuthorStyles: true,
    templateUrl: 'packages/angular_ui/alert/alert.html'
)
class Alert {

What version of the product are you using? On what operating system?
Dart VM version: 1.3.0-dev.7.5 (Fri Mar 28 04:58:12 2014) on "linux_x64"

Please provide any additional information below.

@dgrove
Copy link
Contributor

dgrove commented Apr 1, 2014

Added Area-Formatter, Triaged labels.

@clayberg
Copy link

clayberg commented Apr 2, 2014

Set owner to @pq.
Added this to the 1.4 milestone.
Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-Medium labels.

@DartBot
Copy link
Author

DartBot commented Apr 4, 2014

This comment was originally written by caitpot...@gmail.com


I have a patch for this at https://codereview.chromium.org/226063005 (which might be trying to fix it in the wrong place, the dart tree is very confusing)

@kasperl
Copy link

kasperl commented May 8, 2014

Removed this from the 1.4 milestone.
Added this to the 1.5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@munificent
Copy link
Member

Added AssumedStale label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/dart_style#343.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants