Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose whitelisted two-way binding attributes in the template_binding pkg #17895

Closed
sigmundch opened this issue Mar 28, 2014 · 8 comments
Closed

expose whitelisted two-way binding attributes in the template_binding pkg #17895

sigmundch opened this issue Mar 28, 2014 · 8 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@sigmundch
Copy link
Member

Currently the polymer codegen has a white list matching template binding, but if anything changes we'd fail to recognize it.

See the discussion here:
https://codereview.chromium.org/211393006/diff/90001/pkg/polymer/lib/src/build/script_compactor.dart

(line 579: isTwoWay = ...)
@jmesserly
Copy link

going to say this isn't super important. I bet this will come back to haunt me ;)

Added this to the Later milestone.
Removed Type-Defect label.
Added Type-CodeHealth label.

@jmesserly
Copy link

Removed Area-Polymer label.
Added Area-Pkg label.

@sigmundch
Copy link
Member Author

Removed Priority-Unassigned label.
Added Priority-Low label.

@sigmundch
Copy link
Member Author

Added Polymer-P-2 label.

@sigmundch
Copy link
Member Author

Removed this from the Later milestone.

@sigmundch
Copy link
Member Author

Removed Polymer-P-2 label.
Added Polymer-Milestone-Later label.

@sigmundch
Copy link
Member Author

Removed Polymer-Milestone-Later label.
Added PolymerMilestone-Later label.

@jmesserly
Copy link

dart-archive/polymer-dart#15

Added MovedToGithub label.

@sigmundch sigmundch added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P3 A lower priority bug or feature request Pkg-TemplateBinding area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Feb 4, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmesserly @sigmundch